Guard against similar package names in renamed-package-scope ESLint rule #2732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 3acac4e The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Size Change: 0 B Total Size: 640 kB ℹ️ View Unchanged
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## next #2732 +/- ##
==========================================
+ Coverage 86.93% 87.47% +0.54%
==========================================
Files 211 211
Lines 11906 11906
Branches 1528 1550 +22
==========================================
+ Hits 10350 10415 +65
+ Misses 1506 1441 -65
Partials 50 50 |
sirineJ
approved these changes
Oct 22, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
While upgrading the dashboard to Circuit UI v9, I discovered that the
renamed-package-scopeESLint rule matches unrelated package imports for@sumup/circuit-ui-form.While fixing this issue, I found two broken unit tests. They slipped through because the the global test script doesn't run tests in
packages/eslint-plugin-circuit-uifor some reason.Approach and changes
renamed-package-scopeESLint ruleno-renamed-propsmigration that got lost in the refactor of Migrate to the new typography APIs internally #2728Definition of done