Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update German Translations and few other Fixes #551

Closed
wants to merge 3 commits into from

Conversation

SebastianHira
Copy link

Not sure if the change in README is correct. Only worked with _ for me. If you dont want it, just leave it. The rest is fine

@sumpfork sumpfork self-requested a review December 18, 2024 20:47
Copy link
Owner

@sumpfork sumpfork left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this!

There's an error in updating the language: invalid extra field names for Grey Mustang (de): {'notes'} - seems like an extra field name we're not currently accepting.

Amphore: Entweder jetzt oder zu Beginn deine nächsten Zuges:<br>+1 Kauf and +3 Coin., deine sollte wahrscheinlich deines sein.

Also, it's definitely pre-commit so can you please change that back?

@SebastianHira
Copy link
Author

Working on it. Notes apparently only works in english then. Will remove.

@SebastianHira
Copy link
Author

I'm not sure if I did this correct now. If not, I can try reset head and do it again. Took me the past 2 hours to find out how to change the commit (and I am quite honestly now sure how this worked now as ive mostly just copy pasted random commands from the internet until something worked)

@SebastianHira SebastianHira deleted the update_stuff branch December 20, 2024 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants