German translations for "Rising Sun" #547
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It seems compiling the card DB on this PR produced changes. |
Vielen Dank! Could you re-compile the card db one more time, I think it just needs your small fix (second commit in this PR) integrated perhaps? |
|
Ah indeed, I may have forgot that after the small change. I re-ran the update_language command again and pushed. |
sumpfork
reviewed
Oct 30, 2024
sumpfork
approved these changes
Oct 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey there :)
I added the German translations for all the cards of the "Rising Sun" expansion, which hopefully others are interested to get as well.
Please let me know if there is anything else I need to add or change in order to make the PR correctly.