Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use of pkg_resources #545

Merged
merged 2 commits into from
Oct 18, 2024
Merged

Remove use of pkg_resources #545

merged 2 commits into from
Oct 18, 2024

Conversation

sumpfork
Copy link
Owner

This has come up a couple of times, latest in #544.

pkg_resource from setuptools is deprecated and often not installed (we don't specify it as a runtime dependency anywhere, which is bad.

So, upgrade to use importlib.resources.

Fixes #325.

@sumpfork sumpfork requested a review from nickv2002 October 17, 2024 23:10
@sumpfork sumpfork self-assigned this Oct 17, 2024
Copy link
Collaborator

@nickv2002 nickv2002 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable, this is the kind of thing that if the checks pass we can ship with little concern. :shipit:

@sumpfork sumpfork merged commit 027cdcf into master Oct 18, 2024
7 checks passed
@sumpfork sumpfork deleted the no_pkg_resources branch October 18, 2024 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update resource packaging and access
2 participants