Misc fixes #509
Open
Misc fixes #509
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a deprecation warning from Django, which appears while running tests. 'check' argument is replaced by 'condition'.
_after_postgeneration method will stop saving the instance after postgeneration hooks in the next major release. Solved using Claude, feel free to challenge my fix.
Found this solution googling on Stack Overflow. Without a default ordering on a model, Django raises a warning, that pagination may yield inconsistent results. Please feel free to challenge my fix.
Resolved RemovedInDjango60Warning by ensuring format_html() is called with required arguments, addressing compatibility with Django 6.0. /!\ Fix by Claude, need real-world testing. Linterand tests pass.
output seems to be redefined few lines after. Please feel free to challenge this change.
Found typos while working on the project using my IDE, fixed them. Sorry for the big commit. Not a big deal, can totally drop this commit.
These parentheses seem useless to me, remove them.
Please challenge this commit. I feel these imports aren't used in this migration file.
lebaudantoine
force-pushed
the
fix-warning
branch
from
380c60d to
92f9568
Compare
`sentry_sdk.configure_scope` is deprecated and will be removed in the next major version. (commit taken from people by @qbey)
sampaccoud
approved these changes
Jan 2, 2025
| @@ -619,8 +619,9 @@ def post_setup(cls): | |||
| release=get_release(), | |||
| integrations=[DjangoIntegration()], | |||
| ) | |||
| with sentry_sdk.configure_scope() as scope: | |||
| scope.set_extra("application", "backend") | |||
| # Add the application name to the Sentry scope | |||
There was a problem hiding this comment.
Suggested change
| # Add the application name to the Sentry scope | |
| # Add "application" and "backend" tags the Sentry scope |
There was a problem hiding this comment.
should it be : scope.set_tag("application", "backend")
application was opposed to "worker" for celery if I remember well
There was a problem hiding this comment.
I’ve since noticed that the API has changed to deprecate set_extra in favor of set_context,
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Fix misc small issues (i.e. typos, warnings, etc.)
Proposal
Mostly nit-picking. Please check my commits.
Few warnings are still raised.
One concerns boto, but few PRs address it, boto/botocore#3239.
Will squash commits if you feel it's necessary