Rubocop updates related to v2.6

sugarcrm · Dec 16, 2024 · 7d401fd · 7d401fd
1 parent 0e8c984
commit 7d401fd
Show file tree

Hide file tree

Showing 9 changed files with 23 additions and 7 deletions.
diff --git a/Gemfile b/Gemfile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 source 'https://rubygems.org'
 
 # Specify your gem's dependencies in rspec-side_effects.gemspec

diff --git a/Rakefile b/Rakefile
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/gem_tasks'
 require 'rspec/core/rake_task'
 require 'rubocop/rake_task'

diff --git a/bin/console b/bin/console
@@ -1,4 +1,5 @@
 #!/usr/bin/env ruby
+# frozen_string_literal: true
 
 require 'bundler/setup'
 require 'rspec/side_effects'

diff --git a/doc/dependency_decisions.yml b/doc/dependency_decisions.yml
@@ -5,19 +5,19 @@
     :why: 
     :versions: []
     :when: 2018-06-13 15:20:17.351348000 Z
-- - :whitelist
+- - :permit
   - Apache 2.0
   - :who: Andrew Sullivan Cant <[email protected]>
     :why: SugarCRM's primary approved open source license
     :versions: []
     :when: 2018-06-18 19:28:33.314061000 Z
-- - :whitelist
+- - :permit
   - MIT
   - :who: Andrew Sullivan Cant <[email protected]>
     :why: SugarCRM's secondary approved open source license
     :versions: []
     :when: 2018-06-13 15:18:36.240771000 Z
-- - :whitelist
+- - :permit
   - BSD
   - :who: Andrew Sullivan Cant <[email protected]>
     :why: SugarCRM's secondary approved open source license

diff --git a/lib/rspec/side_effects.rb b/lib/rspec/side_effects.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'rspec/side_effects/version'
 
 module Rspec
@@ -16,11 +18,12 @@ def its_side_effects_are(*options, &block)
 
       describe('side effects', *options) do
         if block
+          # rubocop:disable Lint/HandleExceptions, Lint/RescueException
           before do
-            # rubocop:disable Lint/HandleExceptions, Lint/RescueException
-            begin; subject; rescue Exception; end
-            # rubocop:enable Lint/HandleExceptions, Lint/RescueException
+            subject
+          rescue Exception
           end
+          # rubocop:enable Lint/HandleExceptions, Lint/RescueException
           example(nil, :aggregate_failures, *options, &block)
         else
           example(nil, {}) { subject }

diff --git a/lib/rspec/side_effects/version.rb b/lib/rspec/side_effects/version.rb
@@ -1,5 +1,7 @@
+# frozen_string_literal: true
+
 module Rspec
   module SideEffects
-    VERSION = '0.2.0'.freeze
+    VERSION = '0.2.0'
   end
 end
diff --git a/rspec-side_effects.gemspec b/rspec-side_effects.gemspec
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 lib = File.expand_path('lib', __dir__)
 $LOAD_PATH.unshift(lib) unless $LOAD_PATH.include?(lib)
 require 'rspec/side_effects/version'

diff --git a/spec/rspec/side_effects_spec.rb b/spec/rspec/side_effects_spec.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'spec_helper'
 
 class TestClass

diff --git a/spec/spec_helper.rb b/spec/spec_helper.rb
@@ -1,3 +1,5 @@
+# frozen_string_literal: true
+
 require 'bundler/setup'
 
 # Setup code coverage