Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] no stray parentheses in regexp patterns #4133

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

deathaxe
Copy link
Collaborator

@deathaxe deathaxe commented Jan 8, 2025

This commit scopes stray brackets normally as those may appear in partial patterns. Correct parentheses matching is not always possible and causes valid closing brackets to be scoped illegal.

This commit scopes stray brackets normally as those may appear in partial
patterns. Correct parentheses matching is not always possible and causes
valid closing brackets to be scoped illegal.
@michaelblyons
Copy link
Collaborator

This does work fine, but what do you think about prepending the "stray" bracket scopes instead of replacing the whole context? Otherwise you need to keep it up to date if anything upstream changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants