Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(session): limit max active sessions and calculate session ttl serverside #104

Merged
merged 11 commits into from
Dec 29, 2024
Merged

fix(session): limit max active sessions and calculate session ttl serverside #104

merged 11 commits into from
Dec 29, 2024

Conversation

MikMik1011
Copy link
Member

Closes #98 and #102

@MikMik1011 MikMik1011 changed the title refactor(session): limit max active sessions and calculate session ttl serverside fix(session): limit max active sessions and calculate session ttl serverside Dec 28, 2024
@MikMik1011 MikMik1011 enabled auto-merge December 28, 2024 21:06
@MikMik1011 MikMik1011 linked an issue Dec 28, 2024 that may be closed by this pull request
Max open session #102
Closed
aleksasiriski
aleksasiriski requested changes Dec 29, 2024
View reviewed changes
Copy link
Member

@aleksasiriski aleksasiriski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work, just a few more changes before merging :) Also, remember to squash merge this since your commit messages aren't following semantic release (refactor shouldn't change code logic)

@aleksasiriski aleksasiriski mentioned this pull request Dec 29, 2024
Merged
@aleksasiriski aleksasiriski merged commit e72f5e8 into main Dec 29, 2024
3 checks passed
@aleksasiriski aleksasiriski deleted the ms/refactor/session branch December 29, 2024 22:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aleksasiriski aleksasiriski aleksasiriski requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Max open session Session duration
2 participants
@MikMik1011 @aleksasiriski