Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an optional push/toggle to talk feature #26

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

Noloxs
Copy link

@Noloxs Noloxs commented Sep 27, 2022

Hi, I have made the following features for your consideration.
They are all optional relative to the current implementation, and will only be active if configured to be so.

  • Add feature to allow push to talk (Initial PoC implementation by @tobalr)
  • Add feature to allow toggle to mute/unmute
  • Add a button to app indicator, that toggles mute/unmute
  • Add support for a config file so the user can set
    • To enable and set which key to use for push to talk
    • To enable and set which key to use for toggle
    • The wait duration during type to mute (Also works with type to mute)

NB: python is not my main language, so they may be style issues with my implementation.
Feel free to leave a comment if something should be refactored.

tobalr and others added 8 commits January 21, 2021 22:49
This will allow for the user to define:
- Which key to use for push to talk
- Which key to use for toggle
- The wait duration during type to mute

Add feature to toggle mute/unmute with a single press
Reintroduce initial type to mute

Signed-off-by: Rune Haugaard <[email protected]>
Signed-off-by: Rune Haugaard <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants