Let the Stanza class extend the Builder class. #769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
force-pushed
the
jcbrand/stanza-refactor
branch
from
c2813e3 to
5351b8e
Compare
This enables better compatibility between the two and lets us use Builder methods on Stanza classes.
Make the `toStanzaElement` a static function `Stanza.toElement`
It would be nice to have tests split up into modules, but this causes all kinds of headaches with running the tests in both the browser and NodeJS. So we're keeping them in one file for now.
jcbrand
force-pushed
the
jcbrand/stanza-refactor
branch
from
5351b8e to
623aad4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This enables better compatibility between the two and lets us use Builder methods on Stanza classes.