Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: parentElement not always available depending on context #714

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

H-L
Copy link
Contributor

@H-L H-L commented Jul 15, 2024

Adding a check to use parentNode when parentElement is not available (eg. in some Web Workers contexts)

Closes #711

@jcbrand jcbrand merged commit 39879c3 into strophe:master Jul 16, 2024
1 check passed
@jcbrand
Copy link
Contributor

jcbrand commented Jul 16, 2024

Thanks

@H-L H-L deleted the fix-error-on-parent-element branch July 26, 2024 14:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Error with Builder.up depending on context
2 participants