Refactor in oder to remove circular dependencies #703
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jcbrand
force-pushed
the
jcbrand/remove-circular-deps
branch
2 times, most recently
from
8bc25d5 to
bdd6b58
Compare
- Moved the `serialize` function into the `Builder` - Moved log functions into `./log.js` - Declare `Strophe` in `./index.js` and don't import it from anywhere else. Used `dpdm` to identify circular dependencies: ``` npx dpdm src/index.js --warning=off ```
jcbrand
force-pushed
the
jcbrand/remove-circular-deps
branch
from
bdd6b58 to
0b25039
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
serializefunction into theBuilder./log.jsStrophein./index.jsand don't import it from anywhere else.