Make only scram mandatory extensions abort connection #698
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you @prefiks |
This comment was marked as spam.
This comment was marked as spam.
|
Any blockers to bump it in Converse? |
This comment was marked as spam.
This comment was marked as spam.
|
@Neustradamus can you link to the discussion where ejabberd devs said that's the reason? Else you're spreading fake news/FUD |
|
ejabberd 24.02, which includes the new SCRAM code feature, also includes a workaround to support clients what don't yet support it properly. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I discovered this after adding support for xep-0474 in ejabberd which added
d=...attribute to sasl challenge issued by ejabberd, and this causing problem with client using strophejs.Per RFC5802 point 5.1 only attribute
m=...should result in failure, all other unknown attributes should be ignored, but current version aborts connection when it find any unknown attribute. This pull request changes that to version suggested by RFC.