Issue-1860: Update commons-fileupload:commons-fileupload from 1.3.3 to 1.4

[flaix]

Pull Request Description

This pull request closes strongbox/strongbox#1860

Acceptance Test

• Building the code of the strongbox-parent with mvn clean install still works.
• Building the code of the strongbox project with mvn clean install -Dintegration.tests still works.
• Running mvn spring-boot:run in the strongbox-web-core still starts up the application correctly.
• Building the code and running the strongbox-distribution from a zip or tar.gz still works.
• The tests in the strongbox-web-integration-tests still run properly.

Questions

• Does this pull request break backward compatibility?

  • Yes
  • No

• Does this pull request require other pull requests to be merged first?

  • Yes, please see #...
  • No

• Does this require an update of the documentation?

  • Yes, please see strongbox/strongbox-docs#{PR_NUMBER}
  • No

Code Review And Pre-Merge Checklist

• My code follows the coding convention of this project.
• I have performed a self-review of my own code.
• I have commented my code in hard-to-understand areas.
• My changes generate no new warnings.

[carlspring]

Hi!

Thank you for your contribution!

Would you mind signing the ICLA, as described in the Contributing page?

Also, please, feel free to join our chat channel, if you'd like to learn more about the project and/or like to find out what else you could help with.

Kind regards,

Martin

[flaix]

Signed, sent and reverted.

[carlspring]

Thank you! Congratulations on your first pull request! :)

[carlspring]

As a follow-up task, could you please check, if this upgrade also works for the strongbox issues/1649 branch (you can have a look at #62)? Thanks! :)

[flaix]

I take it that I have to build said branch for strongbox-db myself, as the PR-19 version is not deployed, is it?

[carlspring]

Sounds about right.

[flaix]

Branch issues/1649 still compiles and mvn clean install -Dintegration.tests also runs successfully.
I have not run the SWI tests.

[flaix]

Do you want anything else done with that? I don't think you want the change on branch issues/1649, do you? That would result in conflicts when rebasing that branch onto master.

Man, the integration tests run really long on this branch.

[carlspring]

Thanks for checking this! No need for further pull requests, or rebasing.