Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

issues/1588 janusgraph schema #13

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

issues/1588 janusgraph schema #13

wants to merge 1 commit into from

Conversation

fuss86
Copy link
Contributor

@fuss86 fuss86 commented Nov 24, 2019 •
edited by steve-todorov
Loading

@ghost
Copy link

ghost commented Nov 24, 2019 •
edited by ghost
Loading

DeepCode Report (#537247)

DeepCode analyzed this pull request.
There are 3 new info reports. 2 info reports were fixed.

@fuss86 fuss86 force-pushed the issues/1588 branch 3 times, most recently from 586c495 to 5f2a29b Compare November 27, 2019 23:40
@fuss86
Copy link
Contributor Author

fuss86 commented Dec 1, 2019

Hi @sbespalov ,

unfortunately I need to leave this task for some time so there is a space for you to pick it up and finalize.

The thing is GremlinRequest does not work fine with collections to be persisted. Actually it stores only first element. You can validate it by running StrongboxSchemaTest (note: this test is not finalized completely) and set a breakpoint in line 135 in GremlinRequest. Validate how collection of ChangeSets is persisted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
in progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@fuss86