-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added phase 1 for unit testing with Jacoco #2
base: master
Are you sure you want to change the base?
Conversation
execute using command "mvn clean install" The phase 1 of this commit will build the unit test with Jacoco plugin. Working on phase 2 for adding integration test as well |
hello-world-1/pom.xml
Outdated
<dependency> | ||
<groupId>ae.teletronics.nlp</groupId> | ||
<artifactId>categorisation</artifactId> | ||
<version>1.7-SNAPSHOT</version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We cannot depend on snapshots. Could you please set this to the closest release version?
What is this dependency for?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It appears Intellij automatically added this depedency. We can remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay! Could you please remove it?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I will remove and create a PR
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is already a pull request for this, as far as I recall.
The problem is not so much in the PR, but in the fact that these results are inconclusive. We'd already reached these results. Our numbers ought to be much, much higher. We still need to figure out what's going on.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dinesh19aug I'm confused... You already have a PR? :D
Have you been able to further investigate this? |
Fixed |
No description provided.