Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added phase 1 for unit testing with Jacoco #2

Open
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

dinesh19aug
Copy link

No description provided.

@dinesh19aug
Copy link
Author

execute using command "mvn clean install" The phase 1 of this commit will build the unit test with Jacoco plugin. Working on phase 2 for adding integration test as well

<dependency>
<groupId>ae.teletronics.nlp</groupId>
<artifactId>categorisation</artifactId>
<version>1.7-SNAPSHOT</version>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We cannot depend on snapshots. Could you please set this to the closest release version?

What is this dependency for?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It appears Intellij automatically added this depedency. We can remove this

Copy link
Member

@carlspring carlspring Feb 24, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinesh19aug,

Okay! Could you please remove it?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will remove and create a PR

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinesh19aug ,

There is already a pull request for this, as far as I recall.

The problem is not so much in the PR, but in the fact that these results are inconclusive. We'd already reached these results. Our numbers ought to be much, much higher. We still need to figure out what's going on.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dinesh19aug I'm confused... You already have a PR? :D

@carlspring
Copy link
Member

@dinesh19aug ,

Have you been able to further investigate this?

@dinesh19aug
Copy link
Author

Fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants