Disable Link Login CTA during email lookup #4250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tillh-stripe
previously approved these changes
Nov 13, 2024
...Connections/StripeFinancialConnections/Source/Native/LinkLogin/LinkLoginViewController.swift
Outdated
Show resolved
Hide resolved
Co-authored-by: Till Hellmund <[email protected]>
tillh-stripe
approved these changes
Nov 13, 2024
mats-stripe
deleted the
mats/disable_cta_in_linklogin_pane_during_email_lookup
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a small bug in the Link Login pane where clicking the
Continue with Linkbutton too soon (i.e during thelookuprequest) would prematurely call thesignupendpoint. This now disables that button during thelookuprequest.Motivation
🐛 🔨
Testing
Before:
Screen.Recording.2024-11-12.at.2.46.51.PM.mov
After:
Screen.Recording.2024-11-12.at.2.50.40.PM.mov
Changelog
N/a