Add support for starting Kafka Connect #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mimaison
force-pushed
the
add-connect
branch
from
5e59e88 to
3ba3936
Compare
|
You would need to create more UTs to cover both classes to reach the current threshold. I can show you where to look at it and how to analyze it if you want :). [ERROR] Failed to execute goal org.pitest:pitest-maven:1.17.2:mutationCoverage (default-cli) on project strimzi-test-container: Mutation score of 77 is below threshold of 91 -> [Help 1] |
|
Any pointers would be helpful. As far as I can tell there are tests calling all the methods. |
mimaison
force-pushed
the
add-connect
branch
from
3ba3936 to
ee423be
Compare
Signed-off-by: Mickael Maison <[email protected]>
see-quick
reviewed
Jan 6, 2025
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectCluster.java
Outdated
Show resolved
Hide resolved
src/main/java/io/strimzi/test/container/StrimziConnectContainer.java
Outdated
Show resolved
Hide resolved
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
…r.java Co-authored-by: Maros Orsak <[email protected]> Signed-off-by: Mickael Maison <[email protected]>
see-quick
approved these changes
Jan 7, 2025
Signed-off-by: Mickael Maison <[email protected]>
Signed-off-by: Mickael Maison <[email protected]>
see-quick
reviewed
Jan 13, 2025
src/main/java/io/strimzi/test/container/StrimziConnectContainer.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Mickael Maison <[email protected]>
see-quick
approved these changes
Jan 13, 2025
|
Thanks for the review and help! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Basic support for starting Kafka Connect.