-
-
Notifications
You must be signed in to change notification settings - Fork 960
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: System.Numerics Conversions #2565
Conversation
Not sure why it's breaking and I am not on my dev machine, feel free to investigate further @Doprez if you want to - I'll look into it again next month otherwise |
I can probably find time next week or this weekend. Most people are taking vacations after this week so I should be getting a lot less requests hopefully until January lol. Do you have that Discord discussion mentioned in the other PR available by any chance? |
https://discord.com/channels/500285081265635328/500290856532574209/897483805470908436 got it! Just in case there is some useful info mentioned there. |
Ok so it seems like the issue was just the .NET version at the time. https://www.nuget.org/packages/system.numerics.vectors/#supportedframeworks-body-tab The team city builds are complaining about signing certs which I think is unrelated to this issue. |
I cant even get the android source to build normally in master. maybe @MeharDT or @Basewq can help test this? The errors Im getting are just about it referencing the wrong dll files:
I mean, the good news is the project at least builds but as soon as I try to run it it fails. So I dont think this error has anything to do with the implicit conversions like it did in the past. I followed the instructions to build by deleting the nugets fully and rebuilding from the Stride.Android.sln but it still throws the above error. references for trying to get android to build: |
TC's simple test breaks on this one, so might just be a random issue with this particular branch, you can add the explicit conversion on your branch and I'll try running TC over it |
PR Details
Investigating whether we can cherry pick #1161 now that we've aligned the frameworks - stems from the discussion in #2238.
PR done to run this stuff on TC, work will likely continue in #2238 instead.
Related Issue
None.
Types of changes
Checklist