-
-
Notifications
You must be signed in to change notification settings - Fork 965
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update StrideActivity.cs #2351
base: master
Are you sure you want to change the base?
Update StrideActivity.cs #2351
Conversation
fix android 14
@dotnet-policy-service agree |
Nice work! I think this is a useful workaround but it might be best to keep the PR open and eventually work in the updated Silk.NET binaries as they contain fixes for this and other Android bugs, |
I suspect this might only require a
I think AudioManager does not fall under 'highly privileged apps', but will definitely test to see if this is the case. |
RegisterReceiver(ringerModeIntentReceiver, new IntentFilter(AudioManager.RingerModeChangedAction)); | ||
if (OperatingSystem.IsAndroidVersionAtLeast(34)) | ||
{ | ||
RegisterReceiver(ringerModeIntentReceiver, new IntentFilter(AudioManager.RingerModeChangedAction), ReceiverFlags.Exported); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Have tested this and it looks like it only needs to be ReceiverFlags.NotExported
I suggest you also this whole if-else logic in a single method (eg. something like RegisterRingerReceiver()
) so this logic only needs to be modified in one place.
PR Details
🐞 Bug Fixes
Related Issue
#2349
Types of changes
Checklist