Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update playwright to support Python 3.13 #99

Merged
merged 3 commits into from
Nov 1, 2024
Merged

Update playwright to support Python 3.13 #99

merged 3 commits into from
Nov 1, 2024

Conversation

raethlein
Copy link
Collaborator

@raethlein raethlein commented Nov 1, 2024 •
edited
Loading

We have to update to the latest playwright version in order to support Python 3.13.

See previous upgrade: #84

@raethlein raethlein requested review from a team as code owners November 1, 2024 00:39
@raethlein raethlein requested a review from kajarenc November 1, 2024 01:05
@sfc-gh-kjavadyan
Copy link

LGTM 👍 but probably yarn.lock changes were accidental and aren't connected to PR itself, Is that correct?

I think makes sense to revert it, to not merge 10.000K lines+ git diff here 😄

@raethlein
Copy link
Collaborator Author

LGTM 👍 but probably yarn.lock changes were accidental and aren't connected to PR itself, Is that correct?

I think makes sense to revert it, to not merge 10.000K lines+ git diff here 😄

Ooopsie, thanks for the catch 🙂

@raethlein raethlein merged commit d825287 into master Nov 1, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sfc-gh-kjavadyan sfc-gh-kjavadyan sfc-gh-kjavadyan approved these changes

@kajarenc kajarenc Awaiting requested review from kajarenc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@raethlein @sfc-gh-kjavadyan