Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

makeman: use autodie instead of Fatal #52

Conversation

lkundrak
Copy link

The Fatal(3pm) manual states:

  Fatal has been obsoleted by the new autodie pragma.

As far as makeman.pl is concerned, both do the exact same job.

[[email protected]: This patch has been sitting in Fedora's vpnc package
repository since 2013, with a comment that merely said
"Make it build". I wrote the above commit message, making a guess as to
why was it added.]

@streambinder
Copy link
Owner

Hey @lkundrak, thanks again!
Here as well, the PR looks fine . Fix the commit message and we're good to go :)

The Fatal(3pm) manual states:

  Fatal has been obsoleted by the new autodie pragma.

As far as makeman.pl is concerned, both do the exact same job.

[[email protected]: This patch has been sitting in Fedora's vpnc package
repository since 2013, with a comment that merely said
"Make it build". I wrote the above commit message, making a guess as to
why was it added.]
@lkundrak lkundrak force-pushed the lr/better-to-autodie-than-to-Fatal branch from f023852 to c438b89 Compare November 13, 2024 16:00
@streambinder streambinder merged commit 11e15a1 into streambinder:master Nov 13, 2024
4 checks passed
@streambinder
Copy link
Owner

Thanks a lot!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants