Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sv1-mining-device lib #1249

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

sv1-mining-device lib #1249

wants to merge 2 commits into from

Conversation

jbesraa
Copy link
Contributor

@jbesraa jbesraa commented Nov 14, 2024

Resolves #1245

@jbesraa jbesraa force-pushed the 2024-11-12-sv1-mining-device-lib branch from c33c014 to 9546fe3 Compare November 14, 2024 13:09
@jbesraa jbesraa marked this pull request as ready for review November 14, 2024 13:09
@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-12-sv1-mining-device-lib
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.27
(+0.83%)		47.47
(95.38%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		73.25
(-2.53%)		86.47
(84.72%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.67
(+0.09%)		14.76
(99.42%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		267.41
(-0.38%)		319.05
(83.82%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		610.47
(+3.03%)		694.59
(87.89%)
client_sv2_open_channel📈 view plot
🚷 view threshold		148.44
(+1.01%)		152.19
(97.53%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		288.98
(+0.82%)		314.28
(91.95%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		380.92
(+0.96%)		416.81
(91.39%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		171.68
(+5.30%)		190.58
(90.08%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		465.14
(-0.58%)		583.85
(79.67%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		984.94
(+1.81%)		1,085.87
(90.71%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-12-sv1-mining-device-lib
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,709.60
(-0.73%)		7,800.37
(86.02%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		7,607.90
(-0.79%)		8,817.85
(86.28%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,175.40
(-0.71%)		9,338.14
(87.55%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		867.59
(-1.48%)		1,002.50
(86.54%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		672.81
(-1.04%)		808.60
(83.21%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		244.39
(-1.39%)		266.06
(91.86%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		155.82
(-0.99%)		164.69
(94.62%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,543.50
(+0.12%)		7,702.35
(84.95%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		274.47
(-1.40%)		310.58
(88.37%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		738.97
(-0.69%)		875.43
(84.41%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		596.95
(-1.29%)		697.52
(85.58%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		202.35
(-2.04%)		228.38
(88.60%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-12-sv1-mining-device-lib
Testbedsv2
🚨 5 ALERTS: Threshold Boundary Limits exceeded!
BenchmarkMeasure
Units		ViewBenchmark Result
(Result Δ%)		Lower Boundary
(Limit %)		Upper Boundary
(Limit %)
client_sv2_mining_message_submit_standard_serialize_deserializeEstimated Cycles
estimated cycles		📈 plot
🚨 alert
🚷 threshold		27,758.00
(+0.84%)		27,738.40
(100.07%)
client_sv2_mining_message_submit_standard_serialize_deserializeInstructions
instructions		📈 plot
🚨 alert
🚷 threshold		10,645.00
(+0.63%)		10,640.58
(100.04%)
client_sv2_mining_message_submit_standard_serialize_deserializeL1 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		15,503.00
(+0.71%)		15,489.22
(100.09%)
client_sv2_mining_message_submit_standard_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		92.00
(+13.06%)		90.17
(102.03%)
client_sv2_open_channel_serialize_deserializeL2 Accesses
accesses		📈 plot
🚨 alert
🚷 threshold		87.00
(+17.04%)		85.35
(101.94%)
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,103.00
(+0.51%)		2,203.69
(95.43%)		📈 view plot
🚷 view threshold		473.00
(-0.04%)		488.74
(96.78%)		📈 view plot
🚷 view threshold		733.00
(-0.36%)		757.84
(96.72%)		📈 view plot
🚷 view threshold		8.00
(+45.25%)		14.29
(55.97%)		📈 view plot
🚷 view threshold		38.00
(+0.06%)		41.09
(92.47%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,170.00
(-0.43%)		8,289.80
(98.55%)		📈 view plot
🚷 view threshold		2,137.00
(-0.03%)		2,143.08
(99.72%)		📈 view plot
🚷 view threshold		3,160.00
(-0.03%)		3,170.53
(99.67%)		📈 view plot
🚷 view threshold		36.00
(+1.10%)		42.27
(85.16%)		📈 view plot
🚷 view threshold		138.00
(-0.75%)		140.97
(97.89%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,293.00
(+0.23%)		6,387.63
(98.52%)		📈 view plot
🚷 view threshold		1,750.00
(-0.04%)		1,767.13
(99.03%)		📈 view plot
🚷 view threshold		2,548.00
(-0.22%)		2,576.18
(98.91%)		📈 view plot
🚷 view threshold		21.00
(+23.36%)		24.81
(84.65%)		📈 view plot
🚷 view threshold		104.00
(+0.01%)		106.98
(97.21%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,736.00
(+0.02%)		14,970.78
(98.43%)		📈 view plot
🚷 view threshold		4,694.00
(-0.02%)		4,711.13
(99.64%)		📈 view plot
🚷 view threshold		6,751.00
(-0.11%)		6,782.89
(99.53%)		📈 view plot
🚷 view threshold		50.00
(+14.78%)		53.68
(93.15%)		📈 view plot
🚷 view threshold		221.00
(-0.27%)		227.87
(96.99%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚨 view alert
🚷 view threshold		27,758.00
(+0.84%)		27,738.40
(100.07%)		📈 view plot
🚨 view alert
🚷 view threshold		10,645.00
(+0.63%)		10,640.58
(100.04%)		📈 view plot
🚨 view alert
🚷 view threshold		15,503.00
(+0.71%)		15,489.22
(100.09%)		📈 view plot
🚨 view alert
🚷 view threshold		92.00
(+13.06%)		90.17
(102.03%)		📈 view plot
🚷 view threshold		337.00
(+0.58%)		341.46
(98.69%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,417.00
(+0.42%)		4,617.64
(95.65%)		📈 view plot
🚷 view threshold		1,461.00
(-0.01%)		1,476.74
(98.93%)		📈 view plot
🚷 view threshold		2,157.00
(-0.11%)		2,185.44
(98.70%)		📈 view plot
🚷 view threshold		11.00
(+21.90%)		17.83
(61.69%)		📈 view plot
🚷 view threshold		63.00
(+0.51%)		68.54
(91.91%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		14,028.00
(-0.25%)		14,460.05
(97.01%)		📈 view plot
🚷 view threshold		5,064.00
(-0.00%)		5,079.74
(99.69%)		📈 view plot
🚷 view threshold		7,323.00
(-0.03%)		7,353.23
(99.59%)		📈 view plot
🚷 view threshold		39.00
(+10.86%)		43.49
(89.68%)		📈 view plot
🚷 view threshold		186.00
(-0.79%)		198.91
(93.51%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,866.00
(+0.89%)		22,910.36
(99.81%)		📈 view plot
🚷 view threshold		8,040.00
(+0.26%)		8,074.92
(99.57%)		📈 view plot
🚷 view threshold		11,686.00
(+0.17%)		11,755.49
(99.41%)		📈 view plot
🚨 view alert
🚷 view threshold		87.00
(+17.04%)		85.35
(101.94%)		📈 view plot
🚷 view threshold		307.00
(+1.12%)		312.07
(98.37%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,689.00
(+0.10%)		4,772.91
(98.24%)		📈 view plot
🚷 view threshold		1,502.00
(-0.01%)		1,517.74
(98.96%)		📈 view plot
🚷 view threshold		2,274.00
(-0.19%)		2,299.53
(98.89%)		📈 view plot
🚷 view threshold		14.00
(+50.21%)		15.81
(88.53%)		📈 view plot
🚷 view threshold		67.00
(-0.60%)		69.85
(95.92%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,168.00
(-0.04%)		16,472.86
(98.15%)		📈 view plot
🚷 view threshold		5,963.00
(-0.00%)		5,978.74
(99.74%)		📈 view plot
🚷 view threshold		8,658.00
(-0.06%)		8,692.83
(99.60%)		📈 view plot
🚷 view threshold		46.00
(+14.82%)		53.79
(85.51%)		📈 view plot
🚷 view threshold		208.00
(-0.43%)		216.66
(96.00%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,708.00
(+0.44%)		35,748.11
(99.89%)		📈 view plot
🚷 view threshold		14,888.00
(+0.27%)		14,905.91
(99.88%)		📈 view plot
🚷 view threshold		21,878.00
(+0.31%)		21,916.69
(99.82%)		📈 view plot
🚷 view threshold		99.00
(+6.47%)		114.60
(86.39%)		📈 view plot
🚷 view threshold		381.00
(+0.45%)		384.77
(99.02%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch2024-11-12-sv1-mining-device-lib
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,391.00
(-0.76%)		8,831.12
(95.02%)		📈 view plot
🚷 view threshold		3,689.00
(-1.56%)		3,892.26
(94.78%)		📈 view plot
🚷 view threshold		5,156.00
(-1.89%)		5,461.67
(94.40%)		📈 view plot
🚷 view threshold		10.00
(+39.43%)		12.88
(77.66%)		📈 view plot
🚷 view threshold		91.00
(+0.66%)		96.20
(94.60%)
get_submit📈 view plot
🚷 view threshold		95,449.00
(+0.01%)		96,156.89
(99.26%)		📈 view plot
🚷 view threshold		59,346.00
(-0.21%)		59,819.08
(99.21%)		📈 view plot
🚷 view threshold		85,219.00
(-0.23%)		85,920.46
(99.18%)		📈 view plot
🚷 view threshold		44.00
(-2.91%)		65.24
(67.44%)		📈 view plot
🚷 view threshold		286.00
(+2.19%)		289.49
(98.79%)
get_subscribe📈 view plot
🚷 view threshold		7,872.00
(-1.77%)		8,387.46
(93.85%)		📈 view plot
🚷 view threshold		2,765.00
(-2.42%)		2,971.86
(93.04%)		📈 view plot
🚷 view threshold		3,847.00
(-2.88%)		4,154.24
(92.60%)		📈 view plot
🚷 view threshold		14.00
(+16.59%)		20.75
(67.46%)		📈 view plot
🚷 view threshold		113.00
(-0.95%)		120.16
(94.04%)
serialize_authorize📈 view plot
🚷 view threshold		12,214.00
(-0.48%)		12,655.24
(96.51%)		📈 view plot
🚷 view threshold		5,266.00
(-0.99%)		5,462.16
(96.41%)		📈 view plot
🚷 view threshold		7,324.00
(-1.26%)		7,623.12
(96.08%)		📈 view plot
🚷 view threshold		12.00
(+32.76%)		15.80
(75.97%)		📈 view plot
🚷 view threshold		138.00
(+0.42%)		143.69
(96.04%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,378.00
(-1.23%)		25,289.95
(96.39%)		📈 view plot
🚷 view threshold		9,838.00
(-0.53%)		10,056.39
(97.83%)		📈 view plot
🚷 view threshold		13,888.00
(-0.54%)		14,212.11
(97.72%)		📈 view plot
🚷 view threshold		33.00
(-5.10%)		44.26
(74.56%)		📈 view plot
🚷 view threshold		295.00
(-2.07%)		315.93
(93.37%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,114.00
(-0.66%)		30,799.90
(97.77%)		📈 view plot
🚷 view threshold		12,015.00
(-0.55%)		12,226.77
(98.27%)		📈 view plot
🚷 view threshold		16,999.00
(-0.64%)		17,320.80
(98.14%)		📈 view plot
🚷 view threshold		61.00
(+9.40%)		68.40
(89.18%)		📈 view plot
🚷 view threshold		366.00
(-0.91%)		382.11
(95.79%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,441.00
(-0.03%)		127,204.51
(99.40%)		📈 view plot
🚷 view threshold		73,200.00
(-0.12%)		73,700.75
(99.32%)		📈 view plot
🚷 view threshold		104,911.00
(-0.15%)		105,671.37
(99.28%)		📈 view plot
🚷 view threshold		106.00
(-1.19%)		133.89
(79.17%)		📈 view plot
🚷 view threshold		600.00
(+0.64%)		605.56
(99.08%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		27,498.00
(-1.17%)		28,652.33
(95.97%)		📈 view plot
🚷 view threshold		9,584.00
(-0.65%)		9,791.00
(97.89%)		📈 view plot
🚷 view threshold		13,543.00
(-0.75%)		13,852.09
(97.77%)		📈 view plot
🚷 view threshold		68.00
(+7.03%)		76.16
(89.29%)		📈 view plot
🚷 view threshold		389.00
(-1.78%)		417.32
(93.21%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,163.00
(-0.07%)		115,998.39
(99.28%)		📈 view plot
🚷 view threshold		68,060.00
(-0.07%)		68,515.55
(99.34%)		📈 view plot
🚷 view threshold		97,653.00
(-0.09%)		98,358.92
(99.28%)		📈 view plot
🚷 view threshold		65.00
(+3.32%)		78.84
(82.45%)		📈 view plot
🚷 view threshold		491.00
(+0.00%)		499.69
(98.26%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		22,880.00
(-1.56%)		24,080.39
(95.02%)		📈 view plot
🚷 view threshold		8,143.00
(-0.72%)		8,347.67
(97.55%)		📈 view plot
🚷 view threshold		11,465.00
(-0.77%)		11,759.57
(97.50%)		📈 view plot
🚷 view threshold		36.00
(-3.68%)		44.77
(80.42%)		📈 view plot
🚷 view threshold		321.00
(-2.32%)		349.22
(91.92%)
serialize_submit📈 view plot
🚷 view threshold		99,838.00
(-0.02%)		100,534.34
(99.31%)		📈 view plot
🚷 view threshold		61,408.00
(-0.17%)		61,864.38
(99.26%)		📈 view plot
🚷 view threshold		88,078.00
(-0.21%)		88,768.16
(99.22%)		📈 view plot
🚷 view threshold		49.00
(+4.05%)		65.65
(74.64%)		📈 view plot
🚷 view threshold		329.00
(+1.38%)		334.08
(98.48%)
serialize_subscribe📈 view plot
🚷 view threshold		11,317.00
(-0.68%)		11,767.50
(96.17%)		📈 view plot
🚷 view threshold		4,118.00
(-1.50%)		4,317.65
(95.38%)		📈 view plot
🚷 view threshold		5,707.00
(-1.91%)		6,009.75
(94.96%)		📈 view plot
🚷 view threshold		16.00
(+24.57%)		20.60
(77.68%)		📈 view plot
🚷 view threshold		158.00
(+0.31%)		164.14
(96.26%)
🐰 View full continuous benchmarking report in Bencher

Shourya742
Shourya742 suggested changes Nov 15, 2024
View reviewed changes
Copy link
Contributor

@Shourya742 Shourya742 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor nits and a few follow-ups. Everything else looks good.

roles/test-utils/sv1-mining-device/Cargo.toml
@@ -1,5 +1,5 @@
[package]
name = "sv1-mining-device"
name = "sv1_mining_device"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes sense to keep this consistent with other crates in similar roles. I'm not sure if we've published this crate, but if we have, we should deprecate the previous version.

Copy link
Collaborator

@plebhash plebhash Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this crate has not yet been published to crates.io, so it's still not too late to change things

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on consistency for naming patterns

roles/test-utils/sv1-mining-device/Cargo.toml
@@ -13,6 +13,10 @@ keywords = ["stratum", "mining", "bitcoin", "protocol"]

# See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html

[lib]
name = "sv1_mining_device"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name field can be removed since it's already defined in the [package] section. However, if we want to keep the original package name and use a different library name, including the name field in [lib] makes sense.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is true, however we have been following this same pattern with every roles

in case we decide to change this, IMO it should be a separate PR doing this in a consistent way across all roles

arguably cosmetic and therefore low prio IMHO

roles/test-utils/sv1-mining-device/src/client.rs
@@ -69,8 +67,8 @@ impl Client {
/// the information from `sender_share`, it is formatted as a `v1::client_to_server::Submit`
/// and then serialized into a json message that is sent to the Upstream via
/// `sender_outgoing`.
pub(crate) async fn connect(client_id: u32) {
let stream = std::sync::Arc::new(TcpStream::connect(ADDR).await.unwrap());
pub async fn connect(client_id: u32, upstream_addr: std::net::SocketAddr) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
pub async fn connect(client_id: u32, upstream_addr: std::net::SocketAddr) {
pub async fn connect(client_id: u32, upstream_addr: SocketAddr) {

std::net::SocketAddr can be added to the import statement above.

roles/test-utils/sv1-mining-device/src/main.rs
const ADDR: &str = "127.0.0.1:34255";
Client::connect(
80,
std::net::SocketAddr::from_str(ADDR).expect("Invalid upstream address"),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
std::net::SocketAddr::from_str(ADDR).expect("Invalid upstream address"),
SocketAddr::from_str(ADDR).expect("Invalid upstream address"),

std::net::SocketAddr can be added to the import statement above.

plebhash
plebhash reviewed Nov 15, 2024
View reviewed changes
roles/Cargo.lock
@@ -1,12 +1,12 @@
# This file is automatically @generated by Cargo.
# It is not intended for manual editing.
version = 3
version = 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this breaks MSRV

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I highly recommend locking SRI development setup to Rust 1.75.0

that's what I did with my setup when the same thing happened to me

plebhash
plebhash reviewed Nov 15, 2024
View reviewed changes
roles/tests-integration/tests/common/mod.rs
Comment on lines +293 to +309
pub async fn start_sv2_mining_device(pool_address: SocketAddr) {
tokio::spawn(async move {
mining_device::connect(
pool_address.to_string(),
Some(
Secp256k1PublicKey::from_str("9auqWEzQDVyd2oe1JVGFLMLHZtCo2FFqZwtKA5gd9xbuEu7PH72")
.unwrap(),
),
None,
None,
0,
Some(0.1),
)
.await;
});
tokio::time::sleep(std::time::Duration::from_secs(3)).await;
}
Copy link
Collaborator

@plebhash plebhash Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is leaking from #1252

plebhash
plebhash reviewed Nov 15, 2024
View reviewed changes
roles/tests-integration/Cargo.toml
@@ -23,6 +23,8 @@ once_cell = "1.19.0"
network_helpers_sv2 = { path = "../roles-utils/network-helpers", features =["with_tokio","with_buffer_pool"] }
pool_sv2 = { path = "../pool" }
roles_logic_sv2 = { path = "../../protocols/v2/roles-logic-sv2" }
sv1_mining_device = { path = "../test-utils/sv1-mining-device" }
mining_device = { path = "../test-utils/mining-device" }
Copy link
Collaborator

@plebhash plebhash Nov 15, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this is leaking from #1252

plebhash
plebhash reviewed Nov 15, 2024
View reviewed changes
roles/tests-integration/tests/common/mod.rs
@@ -282,3 +282,28 @@ pub async fn start_template_provider(tp_port: u16) -> TemplateProvider {
template_provider.generate_blocks(16);
template_provider
}

pub async fn start_sv1_mining_device(pool_address: SocketAddr) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

let's try to be consistent with #1234

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also, pool_address is a legacy naming convention that's a bit misleading IMO

I would call this upstream_address

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash left review comments

@Shourya742 Shourya742 Shourya742 requested changes

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create library for mining-device-sv1
3 participants
@jbesraa @Shourya742 @plebhash