Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modularize roles::test-utils::mining-device #1175

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
Draft

Modularize roles::test-utils::mining-device #1175

wants to merge 2 commits into from

Conversation

rrybarczyk
Copy link
Collaborator

Addresses #1174.

@rrybarczyk rrybarczyk added the roles Pertains to all roles label Sep 30, 2024
@rrybarczyk rrybarczyk self-assigned this Sep 30, 2024
@rrybarczyk rrybarczyk linked an issue Sep 30, 2024 that may be closed by this pull request
Difficult to read roles::test-utils::mining-device in single file #1174
Open
4 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

🐰 Bencher Report

Branch1175/merge
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,496.00
(+0.59%)		8,793.21
(96.62%)		📈 view plot
🚷 view threshold		3,746.00
(-0.06%)		3,881.43
(96.51%)		📈 view plot
🚷 view threshold		5,251.00
(-0.11%)		5,440.08
(96.52%)		📈 view plot
🚷 view threshold		5.00
(-28.57%)		11.67
(42.85%)		📈 view plot
🚷 view threshold		92.00
(+2.10%)		95.35
(96.49%)
get_submit📈 view plot
🚷 view threshold		95,379.00
(-0.10%)		96,194.33
(99.15%)		📈 view plot
🚷 view threshold		59,439.00
(-0.05%)		59,795.52
(99.40%)		📈 view plot
🚷 view threshold		85,369.00
(-0.05%)		85,873.72
(99.41%)		📈 view plot
🚷 view threshold		42.00
(-11.26%)		71.09
(59.08%)		📈 view plot
🚷 view threshold		280.00
(-0.22%)		289.77
(96.63%)
get_subscribe📈 view plot
🚷 view threshold		8,089.00
(+0.95%)		8,361.92
(96.74%)		📈 view plot
🚷 view threshold		2,841.00
(+0.15%)		2,963.81
(95.86%)		📈 view plot
🚷 view threshold		3,969.00
(+0.09%)		4,135.68
(95.97%)		📈 view plot
🚷 view threshold		12.00
(-6.57%)		23.14
(51.86%)		📈 view plot
🚷 view threshold		116.00
(+1.94%)		119.65
(96.95%)
serialize_authorize📈 view plot
🚷 view threshold		12,343.00
(+0.70%)		12,637.40
(97.67%)		📈 view plot
🚷 view threshold		5,317.00
(-0.04%)		5,452.43
(97.52%)		📈 view plot
🚷 view threshold		7,413.00
(-0.08%)		7,602.47
(97.51%)		📈 view plot
🚷 view threshold		6.00
(-33.79%)		14.92
(40.21%)		📈 view plot
🚷 view threshold		140.00
(+2.23%)		143.84
(97.33%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,777.00
(+0.65%)		25,152.16
(98.51%)		📈 view plot
🚷 view threshold		9,868.00
(-0.27%)		10,052.80
(98.16%)		📈 view plot
🚷 view threshold		13,927.00
(-0.28%)		14,197.64
(98.09%)		📈 view plot
🚷 view threshold		35.00
(+0.02%)		44.19
(79.21%)		📈 view plot
🚷 view threshold		305.00
(+1.90%)		313.69
(97.23%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,410.00
(+0.47%)		30,728.83
(98.96%)		📈 view plot
🚷 view threshold		12,071.00
(-0.15%)		12,226.21
(98.73%)		📈 view plot
🚷 view threshold		17,090.00
(-0.15%)		17,307.63
(98.74%)		📈 view plot
🚷 view threshold		60.00
(+7.01%)		68.45
(87.66%)		📈 view plot
🚷 view threshold		372.00
(+1.16%)		381.01
(97.64%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,526.00
(+0.05%)		127,173.35
(99.49%)		📈 view plot
🚷 view threshold		73,280.00
(+0.00%)		73,672.68
(99.47%)		📈 view plot
🚷 view threshold		105,051.00
(+0.00%)		105,618.11
(99.46%)		📈 view plot
🚷 view threshold		109.00
(-0.83%)		141.99
(76.76%)		📈 view plot
🚷 view threshold		598.00
(+0.31%)		604.77
(98.88%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		28,078.00
(+1.27%)		28,601.55
(98.17%)		📈 view plot
🚷 view threshold		9,659.00
(+0.13%)		9,779.90
(98.76%)		📈 view plot
🚷 view threshold		13,653.00
(+0.06%)		13,830.49
(98.72%)		📈 view plot
🚷 view threshold		71.00
(+11.28%)		76.05
(93.36%)		📈 view plot
🚷 view threshold		402.00
(+2.23%)		416.47
(96.53%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,249.00
(+0.05%)		115,897.90
(99.44%)		📈 view plot
🚷 view threshold		68,057.00
(-0.04%)		68,472.52
(99.39%)		📈 view plot
🚷 view threshold		97,654.00
(-0.05%)		98,282.60
(99.36%)		📈 view plot
🚷 view threshold		61.00
(-4.36%)		81.61
(74.75%)		📈 view plot
🚷 view threshold		494.00
(+0.73%)		499.50
(98.90%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,473.00
(+1.39%)		24,012.30
(97.75%)		📈 view plot
🚷 view threshold		8,211.00
(+0.12%)		8,335.36
(98.51%)		📈 view plot
🚷 view threshold		11,563.00
(+0.10%)		11,737.36
(98.51%)		📈 view plot
🚷 view threshold		37.00
(-1.62%)		44.39
(83.36%)		📈 view plot
🚷 view threshold		335.00
(+2.76%)		348.30
(96.18%)
serialize_submit📈 view plot
🚷 view threshold		99,844.00
(-0.03%)		100,539.65
(99.31%)		📈 view plot
🚷 view threshold		61,483.00
(-0.05%)		61,844.22
(99.42%)		📈 view plot
🚷 view threshold		88,209.00
(-0.05%)		88,725.80
(99.42%)		📈 view plot
🚷 view threshold		45.00
(-7.44%)		70.24
(64.07%)		📈 view plot
🚷 view threshold		326.00
(+0.32%)		333.35
(97.79%)
serialize_subscribe📈 view plot
🚷 view threshold		11,494.00
(+0.90%)		11,762.15
(97.72%)		📈 view plot
🚷 view threshold		4,188.00
(+0.10%)		4,310.81
(97.15%)		📈 view plot
🚷 view threshold		5,824.00
(+0.03%)		5,992.57
(97.19%)		📈 view plot
🚷 view threshold		14.00
(+2.93%)		22.24
(62.96%)		📈 view plot
🚷 view threshold		160.00
(+1.79%)		164.52
(97.25%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

🐰 Bencher Report

Branch1175/merge
Testbedsv1
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client-submit-serialize📈 view plot
🚷 view threshold		6,962.00
(+0.45%)		7,334.89
(94.92%)
client-submit-serialize-deserialize📈 view plot
🚷 view threshold		8,287.60
(+3.83%)		8,586.04
(96.52%)
client-submit-serialize-deserialize-handle/client-submit-serialize-deserialize-handle📈 view plot
🚷 view threshold		8,426.40
(-1.21%)		9,079.80
(92.80%)
client-sv1-authorize-serialize-deserialize-handle/client-sv1-authorize-serialize-deserialize-handle📈 view plot
🚷 view threshold		933.38
(+1.71%)		976.95
(95.54%)
client-sv1-authorize-serialize-deserialize/client-sv1-authorize-serialize-deserialize📈 view plot
🚷 view threshold		718.28
(+0.08%)		764.33
(93.98%)
client-sv1-authorize-serialize/client-sv1-authorize-serialize📈 view plot
🚷 view threshold		249.95
(+0.35%)		265.28
(94.22%)
client-sv1-get-authorize/client-sv1-get-authorize📈 view plot
🚷 view threshold		161.00
(+1.64%)		167.70
(96.01%)
client-sv1-get-submit📈 view plot
🚷 view threshold		6,701.30
(+0.05%)		7,182.48
(93.30%)
client-sv1-get-subscribe/client-sv1-get-subscribe📈 view plot
🚷 view threshold		276.76
(-0.26%)		289.50
(95.60%)
client-sv1-subscribe-serialize-deserialize-handle/client-sv1-subscribe-serialize-deserialize-handle📈 view plot
🚷 view threshold		786.85
(+2.25%)		836.08
(94.11%)
client-sv1-subscribe-serialize-deserialize/client-sv1-subscribe-serialize-deserialize📈 view plot
🚷 view threshold		624.78
(-1.69%)		674.18
(92.67%)
client-sv1-subscribe-serialize/client-sv1-subscribe-serialize📈 view plot
🚷 view threshold		204.61
(-2.20%)		235.26
(86.97%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

🐰 Bencher Report

Branch1175/merge
Testbedsv2
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		2,099.00
(+1.04%)		2,209.02
(95.02%)		📈 view plot
🚷 view threshold		473.00
(+0.21%)		490.73
(96.39%)		📈 view plot
🚷 view threshold		734.00
(-0.01%)		761.80
(96.35%)		📈 view plot
🚷 view threshold		7.00
(+19.63%)		14.28
(49.03%)		📈 view plot
🚷 view threshold		38.00
(+1.21%)		41.27
(92.09%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		8,212.00
(+0.14%)		8,349.10
(98.36%)		📈 view plot
🚷 view threshold		2,137.00
(+0.15%)		2,177.88
(98.12%)		📈 view plot
🚷 view threshold		3,157.00
(+0.06%)		3,225.47
(97.88%)		📈 view plot
🚷 view threshold		38.00
(+3.84%)		45.07
(84.32%)		📈 view plot
🚷 view threshold		139.00
(+0.04%)		142.32
(97.66%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		6,289.00
(+0.16%)		6,414.33
(98.05%)		📈 view plot
🚷 view threshold		1,750.00
(-0.01%)		1,767.95
(98.98%)		📈 view plot
🚷 view threshold		2,549.00
(-0.17%)		2,580.69
(98.77%)		📈 view plot
🚷 view threshold		20.00
(+17.43%)		24.80
(80.64%)		📈 view plot
🚷 view threshold		104.00
(-0.01%)		107.76
(96.51%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		14,690.00
(-0.38%)		15,052.79
(97.59%)		📈 view plot
🚷 view threshold		4,694.00
(-0.01%)		4,711.95
(99.62%)		📈 view plot
🚷 view threshold		6,755.00
(-0.03%)		6,783.70
(99.58%)		📈 view plot
🚷 view threshold		47.00
(+5.73%)		55.17
(85.19%)		📈 view plot
🚷 view threshold		220.00
(-0.86%)		230.42
(95.48%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		27,472.00
(-0.12%)		27,892.84
(98.49%)		📈 view plot
🚷 view threshold		10,585.00
(+0.17%)		10,639.41
(99.49%)		📈 view plot
🚷 view threshold		15,402.00
(+0.17%)		15,481.97
(99.48%)		📈 view plot
🚷 view threshold		83.00
(+1.62%)		90.50
(91.71%)		📈 view plot
🚷 view threshold		333.00
(-0.55%)		345.86
(96.28%)
client_sv2_open_channel📈 view plot
🚷 view threshold		4,375.00
(-1.03%)		4,668.00
(93.72%)		📈 view plot
🚷 view threshold		1,461.00
(+0.03%)		1,477.94
(98.85%)		📈 view plot
🚷 view threshold		2,160.00
(+0.12%)		2,186.08
(98.81%)		📈 view plot
🚷 view threshold		9.00
(-7.02%)		18.48
(48.70%)		📈 view plot
🚷 view threshold		62.00
(-2.02%)		69.83
(88.78%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		13,982.00
(-0.88%)		14,522.91
(96.28%)		📈 view plot
🚷 view threshold		5,064.00
(+0.01%)		5,080.94
(99.67%)		📈 view plot
🚷 view threshold		7,327.00
(+0.05%)		7,353.53
(99.64%)		📈 view plot
🚷 view threshold		36.00
(+1.92%)		43.58
(82.60%)		📈 view plot
🚷 view threshold		185.00
(-1.98%)		200.61
(92.22%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		22,663.00
(+0.11%)		23,031.22
(98.40%)		📈 view plot
🚷 view threshold		8,027.00
(+0.23%)		8,079.65
(99.35%)		📈 view plot
🚷 view threshold		11,668.00
(+0.15%)		11,756.11
(99.25%)		📈 view plot
🚷 view threshold		85.00
(+15.32%)		85.45
(99.48%)		📈 view plot
🚷 view threshold		302.00
(-0.46%)		314.74
(95.95%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		4,669.00
(-0.38%)		4,779.71
(97.68%)		📈 view plot
🚷 view threshold		1,502.00
(+0.03%)		1,518.94
(98.88%)		📈 view plot
🚷 view threshold		2,279.00
(+0.06%)		2,304.83
(98.88%)		📈 view plot
🚷 view threshold		9.00
(-1.29%)		15.46
(58.21%)		📈 view plot
🚷 view threshold		67.00
(-0.79%)		70.20
(95.44%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		16,122.00
(-0.46%)		16,509.39
(97.65%)		📈 view plot
🚷 view threshold		5,963.00
(+0.01%)		5,979.94
(99.72%)		📈 view plot
🚷 view threshold		8,662.00
(+0.02%)		8,692.66
(99.65%)		📈 view plot
🚷 view threshold		43.00
(+4.16%)		54.78
(78.49%)		📈 view plot
🚷 view threshold		207.00
(-1.15%)		217.73
(95.07%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		35,556.00
(+0.02%)		35,779.33
(99.38%)		📈 view plot
🚷 view threshold		14,855.00
(+0.13%)		14,908.72
(99.64%)		📈 view plot
🚷 view threshold		21,821.00
(+0.13%)		21,912.40
(99.58%)		📈 view plot
🚷 view threshold		94.00
(-0.22%)		115.80
(81.17%)		📈 view plot
🚷 view threshold		379.00
(-0.14%)		385.06
(98.43%)
🐰 View full continuous benchmarking report in Bencher

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Sep 30, 2024 •
edited
Loading

🐰 Bencher Report

Branch1175/merge
Testbedsv2
Click to view all benchmark results
BenchmarkLatencyBenchmark Result
nanoseconds (ns)
(Result Δ%)		Upper Boundary
nanoseconds (ns)
(Limit %)
client_sv2_handle_message_common📈 view plot
🚷 view threshold		45.49
(+1.91%)		46.17
(98.53%)
client_sv2_handle_message_mining📈 view plot
🚷 view threshold		73.46
(-2.41%)		92.13
(79.73%)
client_sv2_mining_message_submit_standard📈 view plot
🚷 view threshold		14.75
(+0.39%)		14.89
(99.08%)
client_sv2_mining_message_submit_standard_serialize📈 view plot
🚷 view threshold		275.50
(+3.48%)		288.40
(95.53%)
client_sv2_mining_message_submit_standard_serialize_deserialize📈 view plot
🚷 view threshold		598.27
(+1.16%)		639.29
(93.58%)
client_sv2_open_channel📈 view plot
🚷 view threshold		163.00
(-1.67%)		178.47
(91.33%)
client_sv2_open_channel_serialize📈 view plot
🚷 view threshold		271.22
(-1.01%)		301.11
(90.07%)
client_sv2_open_channel_serialize_deserialize📈 view plot
🚷 view threshold		374.32
(-1.02%)		430.68
(86.91%)
client_sv2_setup_connection📈 view plot
🚷 view threshold		163.66
(+1.27%)		185.54
(88.21%)
client_sv2_setup_connection_serialize📈 view plot
🚷 view threshold		475.87
(+6.11%)		514.40
(92.51%)
client_sv2_setup_connection_serialize_deserialize📈 view plot
🚷 view threshold		935.68
(-5.47%)		1,111.26
(84.20%)
🐰 View full continuous benchmarking report in Bencher

@rrybarczyk
Copy link
Collaborator Author

@plebhash and @jbesraa. I have modularized the crate. I made the choice to keep all types as private as possible (most of the time things are pub(crate). Thoughts on this?

Also, I want to add more to the README, better explaining what the crate is and when it can be used for. If you have any thoughts on this, please drop an early review or comment.

@github-actions GitHub Actions
Copy link
Contributor

🐰 Bencher Report

Branch1175/merge@4150cf94-a5de-4d9f-b0e4-c6a3651f35e1/1
Testbedsv1
Click to view all benchmark results
BenchmarkEstimated CyclesBenchmark Result
estimated cycles
(Result Δ%)		Upper Boundary
estimated cycles
(Limit %)		InstructionsBenchmark Result
instructions
(Result Δ%)		Upper Boundary
instructions
(Limit %)		L1 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		L2 AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)		RAM AccessesBenchmark Result
accesses
(Result Δ%)		Upper Boundary
accesses
(Limit %)
get_authorize📈 view plot
🚷 view threshold		8,496.00
(+0.59%)		8,793.21
(96.62%)		📈 view plot
🚷 view threshold		3,746.00
(-0.06%)		3,881.43
(96.51%)		📈 view plot
🚷 view threshold		5,251.00
(-0.11%)		5,440.08
(96.52%)		📈 view plot
🚷 view threshold		5.00
(-28.57%)		11.67
(42.85%)		📈 view plot
🚷 view threshold		92.00
(+2.10%)		95.35
(96.49%)
get_submit📈 view plot
🚷 view threshold		95,379.00
(-0.10%)		96,194.33
(99.15%)		📈 view plot
🚷 view threshold		59,439.00
(-0.05%)		59,795.52
(99.40%)		📈 view plot
🚷 view threshold		85,369.00
(-0.05%)		85,873.72
(99.41%)		📈 view plot
🚷 view threshold		42.00
(-11.26%)		71.09
(59.08%)		📈 view plot
🚷 view threshold		280.00
(-0.22%)		289.77
(96.63%)
get_subscribe📈 view plot
🚷 view threshold		8,089.00
(+0.95%)		8,361.92
(96.74%)		📈 view plot
🚷 view threshold		2,841.00
(+0.15%)		2,963.81
(95.86%)		📈 view plot
🚷 view threshold		3,969.00
(+0.09%)		4,135.68
(95.97%)		📈 view plot
🚷 view threshold		12.00
(-6.57%)		23.14
(51.86%)		📈 view plot
🚷 view threshold		116.00
(+1.94%)		119.65
(96.95%)
serialize_authorize📈 view plot
🚷 view threshold		12,343.00
(+0.70%)		12,637.40
(97.67%)		📈 view plot
🚷 view threshold		5,317.00
(-0.04%)		5,452.43
(97.52%)		📈 view plot
🚷 view threshold		7,413.00
(-0.08%)		7,602.47
(97.51%)		📈 view plot
🚷 view threshold		6.00
(-33.79%)		14.92
(40.21%)		📈 view plot
🚷 view threshold		140.00
(+2.23%)		143.84
(97.33%)
serialize_deserialize_authorize📈 view plot
🚷 view threshold		24,773.00
(+0.63%)		25,152.03
(98.49%)		📈 view plot
🚷 view threshold		9,868.00
(-0.27%)		10,052.80
(98.16%)		📈 view plot
🚷 view threshold		13,928.00
(-0.27%)		14,197.63
(98.10%)		📈 view plot
🚷 view threshold		34.00
(-2.81%)		44.18
(76.95%)		📈 view plot
🚷 view threshold		305.00
(+1.90%)		313.69
(97.23%)
serialize_deserialize_handle_authorize📈 view plot
🚷 view threshold		30,444.00
(+0.59%)		30,730.01
(99.07%)		📈 view plot
🚷 view threshold		12,071.00
(-0.15%)		12,226.21
(98.73%)		📈 view plot
🚷 view threshold		17,089.00
(-0.16%)		17,307.63
(98.74%)		📈 view plot
🚷 view threshold		60.00
(+7.01%)		68.45
(87.66%)		📈 view plot
🚷 view threshold		373.00
(+1.43%)		381.04
(97.89%)
serialize_deserialize_handle_submit📈 view plot
🚷 view threshold		126,522.00
(+0.05%)		127,173.29
(99.49%)		📈 view plot
🚷 view threshold		73,280.00
(+0.00%)		73,672.68
(99.47%)		📈 view plot
🚷 view threshold		105,052.00
(+0.01%)		105,618.12
(99.46%)		📈 view plot
🚷 view threshold		108.00
(-1.73%)		141.99
(76.06%)		📈 view plot
🚷 view threshold		598.00
(+0.31%)		604.77
(98.88%)
serialize_deserialize_handle_subscribe📈 view plot
🚷 view threshold		28,086.00
(+1.29%)		28,601.86
(98.20%)		📈 view plot
🚷 view threshold		9,659.00
(+0.13%)		9,779.90
(98.76%)		📈 view plot
🚷 view threshold		13,651.00
(+0.04%)		13,830.47
(98.70%)		📈 view plot
🚷 view threshold		73.00
(+14.38%)		76.17
(95.84%)		📈 view plot
🚷 view threshold		402.00
(+2.23%)		416.47
(96.53%)
serialize_deserialize_submit📈 view plot
🚷 view threshold		115,245.00
(+0.05%)		115,897.84
(99.44%)		📈 view plot
🚷 view threshold		68,057.00
(-0.04%)		68,472.52
(99.39%)		📈 view plot
🚷 view threshold		97,655.00
(-0.05%)		98,282.60
(99.36%)		📈 view plot
🚷 view threshold		60.00
(-5.92%)		81.62
(73.51%)		📈 view plot
🚷 view threshold		494.00
(+0.73%)		499.50
(98.90%)
serialize_deserialize_subscribe📈 view plot
🚷 view threshold		23,473.00
(+1.39%)		24,012.30
(97.75%)		📈 view plot
🚷 view threshold		8,211.00
(+0.12%)		8,335.36
(98.51%)		📈 view plot
🚷 view threshold		11,563.00
(+0.10%)		11,737.36
(98.51%)		📈 view plot
🚷 view threshold		37.00
(-1.62%)		44.39
(83.36%)		📈 view plot
🚷 view threshold		335.00
(+2.76%)		348.30
(96.18%)
serialize_submit📈 view plot
🚷 view threshold		99,844.00
(-0.03%)		100,539.65
(99.31%)		📈 view plot
🚷 view threshold		61,483.00
(-0.05%)		61,844.22
(99.42%)		📈 view plot
🚷 view threshold		88,209.00
(-0.05%)		88,725.80
(99.42%)		📈 view plot
🚷 view threshold		45.00
(-7.44%)		70.24
(64.07%)		📈 view plot
🚷 view threshold		326.00
(+0.32%)		333.35
(97.79%)
serialize_subscribe📈 view plot
🚷 view threshold		11,494.00
(+0.90%)		11,762.15
(97.72%)		📈 view plot
🚷 view threshold		4,188.00
(+0.10%)		4,310.81
(97.15%)		📈 view plot
🚷 view threshold		5,824.00
(+0.03%)		5,992.57
(97.19%)		📈 view plot
🚷 view threshold		14.00
(+2.93%)		22.24
(62.96%)		📈 view plot
🚷 view threshold		160.00
(+1.79%)		164.52
(97.25%)
🐰 View full continuous benchmarking report in Bencher

plebhash
plebhash reviewed Sep 30, 2024
View reviewed changes
roles/test-utils/mining-device/README.md
@@ -15,7 +15,18 @@ Options:
-V, --version Print version
```

Usage example:
## Example
1. Start a pool. The hosted example in the [`pool`](https://github.com/stratum-mining/stratum/tree/main/roles/pool)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this line is not clear with regards to what "hosted" means

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Agree. I was referring to pool-config-hosted-tp-example.toml. I will add clarity here that this is the SRI community hosted pool server.

jbesraa
jbesraa reviewed Oct 3, 2024
View reviewed changes
Copy link
Contributor

@jbesraa jbesraa left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

General concept ACK.

I wouldn't move NewWorkNotifier, NextShareOutcome and SetupConnectionHandler into separate files though. Each one of them is only used once either in device or in miner, they are private and not exported from the crate and they are fairly small. I think moving them into device/miner, wherever they are used, would make more sense and improve the general readability of the crate.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@plebhash plebhash plebhash left review comments

@jbesraa jbesraa jbesraa left review comments

At least 1 approving review is required to merge this pull request.

Assignees

@rrybarczyk rrybarczyk

Labels
roles Pertains to all roles
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Difficult to read roles::test-utils::mining-device in single file
3 participants
@rrybarczyk @jbesraa @plebhash