feat(cli): added parser arg #2737
Open
+26
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rudfoss-rr
force-pushed
the
feat/cli/parser-arg
branch
from
ca1ef59
to
59d45a8
Compare
|
@mnaumanali94 I was having trouble fixing the commit message issues so I reopened a new PR instead. Sorry for the confusion. I've addressed the lint issues, but I'm having trouble getting all tests to work as well as adding appropriate tests of my own. Would love some help if you have time as I haven't worked with test-harness before and can't seem to get them to run locally in dev-container. |
4 tasks
|
@rudfoss-rr So to run harness tests you first need to build the binaries. For that cd into the package/cli folder and run |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Does this PR introduce a breaking change?
Additional context
Suggestion for adding support for a
parserargument to the CLI so that the appropriate parser can be selected for Json files.