Inject an AttributeReader when annotations are disabled

[stof]

This avoids triggering the fallback path of instantiating an (uncached) annotation reader in the extensions in case annotations are disabled in FrameworkBundle but the doctrine/annotations package is still installed.

Closes #481

[igordeveloper]

@stof ,

Could you please help with a doubt?

Is there a way to tell whether I can choose annotations or attributes? If I have another bundle that still injects the annotations reader into the container, will stof instantiate annotations reader as default?

Are there any other releases that already make this possible?

thank you so much

[stof]

This bundle does not instantiate an annotation reader. It uses the annotation_reader service if it exists in the container.

However, note that enabling the support of annotations does not disable support for attributes. The Gedmo extensions support attributes all the time on PHP 8+.

[igordeveloper]

This bundle does not instantiate an annotation reader. It uses the annotation_reader service if it exists in the container.

However, note that enabling the support of annotations does not disable support for attributes. The Gedmo extensions support attributes all the time on PHP 8+.

Yes, i'm using attributes with Gedmo,
My question is relationed the deprecation message:

Annotations support is deprecated, migrate your application to use attributes and pass an instance of Gedmo\Mapping\Driver\AttributeReader

My project there annotation_reader active in the container yet, Is there any way to not use the annotation_reader without the search being through the container?

Thank you for the feedback.

[stof]

@igordeveloper if you cannot disable the support of annotations from the FrameworkBundle configuration (because something still needs annotations in your project), no.
Note that FrameworkBundle supports disabling the support for annotations (thus not defining the annotation_reader service) even if doctrine/annotations is still installed (it will enable annotations by default based on the presence of the package, but you can always set an explicit enabled: false)

[igordeveloper]

@igordeveloper if you cannot disable the support of annotations from the FrameworkBundle configuration (because something still needs annotations in your project), no. Note that FrameworkBundle supports disabling the support for annotations (thus not defining the annotation_reader service) even if doctrine/annotations is still installed (it will enable annotations by default based on the presence of the package, but you can always set an explicit enabled: false)

Yes, i have disabled in the framework, but unfortunately I have 2 packages using still annotations.

Thanks for the answer and you time.

[stof]

If it is disabled in the framework, this PR should be solving the deprecation you report (assuming you use this bundle to configure the Gedmo listeners of course. If you configure them yourselves, there is no point commenting on this bundle at all)

[igordeveloper]

If it is disabled in the framework, this PR should be solving the deprecation you report (assuming you use this bundle to configure the Gedmo listeners of course. If you configure them yourselves, there is no point commenting on this bundle at all)

I will check if i disable correclty,
Yes, i use this bundle to configure Gedmo Listeners.

thank you.

[igordeveloper]

@stof

thank you for the help.

The problem with annotation deprecations was solved here.