Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add https support #6

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bilal-mk
Copy link

@bilal-mk bilal-mk commented Feb 2, 2018

No description provided.

@simmel
Copy link
Member

simmel commented Feb 2, 2018

Thanks for the contribution @bilal-mk !

I won't disable verification of the hostname, though. If you want you can disabled it with an environment variable, see the documentation, but I will not incorporate an insecure by default setting.

Why do you want to limit the protocols supported? While I don't think that Elasticsearch will ever support e.g. the ftp protocol ; ) I don't really see a point to limit them. What was the thought here?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants