resolve all warnings and clippy lints #298
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Crzyrndm
commented
Mar 6, 2022
| @@ -9,6 +9,7 @@ | |||
| //! the STM32L432KC microcontroller. Participation is of course very welcome! | |||
|
|
|||
| #![no_std] | |||
| #![allow(clippy::upper_case_acronyms)] | |||
There was a problem hiding this comment.
This was causing peripheral / register defines to raise clippy warnings. It was only in a single module IIRC, so could move this to only the scope of that module potentially?
| @@ -158,12 +158,24 @@ impl RtcConfig { | |||
| } | |||
|
|
|||
| impl Rtc { | |||
| #[allow(clippy::self_named_constructors)] | |||
| #[deprecated = "use `new()` instead"] | |||
There was a problem hiding this comment.
This is potentially controversial. Opinions?
Also has conflicts with #297 (whichever is merged last will need modifications to suppress the deprecation warnings assuming this remains)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Any remaining warnings lints should be in
examples/and resolved by #297