Added the possibility to configure PWM as open drain output #84
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
usbalbin
reviewed
Dec 18, 2023
src/pwm.rs
Outdated
| PF9<Alternate<AF3>>, | ||
|
|
||
| #[cfg(feature = "pwm-open-drain")] | ||
| PA2<AlternateOD<AF9>>, |
There was a problem hiding this comment.
What about changing the pin! macro so that we only need to specify pin and alternate function here? The macro would then generate the things both for Alternate and AlternateOD. This would avoid some repetition, not sure if it is worth the extra complexity though. Just a thought :) ...
So instead of having to specify
PA2<Alternate<AF9>>,
PA2<AlternateOD<AF9>>,, something like this would suffice
PA2: AF9,There was a problem hiding this comment.
I think that's a good suggestion. I will pick this up after the Christmas holidays. Thank you.
There was a problem hiding this comment.
I changed the pin macro as you suggested.
added 2 commits
January 22, 2024 15:23
usbalbin
reviewed
Jul 27, 2024
| (BRK2: #[ $( $pmeta:meta )* ] $PINBRK2:ident, $ALTBRK2:ty, $TIMX:ty) => { | ||
| $( #[ $pmeta ] )* | ||
| impl FaultPins<$TIMX> for $PINBRK2<Alternate<$ALTBRK2>> { | ||
| const INPUT: BreakInput = BreakInput::BreakIn; |
There was a problem hiding this comment.
Should this be changed to
Suggested change
| const INPUT: BreakInput = BreakInput::BreakIn; | |
| const INPUT: BreakInput = BreakInput::BreakIn2; |
?
|
What about going as far as something like this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.