Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

close HTTPClient when running with JDK21 or newer #70

Merged
merged 2 commits into from
Nov 26, 2023
Merged

close HTTPClient when running with JDK21 or newer #70

merged 2 commits into from
Nov 26, 2023

Commits on Nov 26, 2023

  1. close HTTPClient when running with JDK21 or newer (#70) 

    The Java HTTP client implements AutoCloseable since JDK 21. Closing the
client ensures that asynchronous operations and streams are properly
terminated.

As we support Java 11, we add any old school "finally" wrapper and
conditionally close the client when running on a modern platform.
    @stklcode
    stklcode committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    52876ef View commit details
    Browse the repository at this point in the history

  2. ci: run coverage analysis with JDK 21 

    The JDK 21 build with Vault 1.11 seems to be the only job with full
coverage on conditional code.
    @stklcode
    stklcode committed Nov 26, 2023
    Configuration menu
    Copy the full SHA
    56d5345 View commit details
    Browse the repository at this point in the history