parse timestamps as ZonedDateTime internally #64
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Timestamps have been stored with their String representation from the API with convenience methods to convert them into ZonedDateTime. We now use the Jackson JavaTimeModule to parse them directly and swap the real and convenience getters.
stklcode
force-pushed
the
feature/datetime
branch
from
c560c38
to
247aa31
Compare
stklcode
force-pushed
the
feature/datetime
branch
2 times, most recently
from
381adc2
to
f8bddf7
Compare
stklcode
force-pushed
the
feature/datetime
branch
from
f8bddf7
to
62176cb
Compare
stklcode
force-pushed
the
feature/datetime
branch
from
62176cb
to
7e5d193
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Timestamps have been stored with their
Stringrepresentation from the API with convenience methods to convert them intoZonedDateTime. We now use the JacksonJavaTimeModuleto parse them directly and swap the real and convenience getters.The
get...TimeString()methods are now deprecated.