test: add format idempotency test #285
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
peterhuene
requested review from
peterhuene,
adthrasher,
claymcleod and
a-frantz
|
It looks like the latest Rust toolchain introduced some new static analysis warnings. We'll work on fixing the source and we can rebase all affected PRs once it merges. |
a-frantz
reviewed
Jan 10, 2025
adthrasher
approved these changes
Jan 10, 2025
|
You should be good to rebase your changes on the |
claymcleod
force-pushed
the
format-idempotent
branch
from
8d2ac3f to
a853679
Compare
a-frantz
force-pushed
the
format-idempotent
branch
from
a853679 to
7f2508e
Compare
adthrasher
reviewed
Jan 13, 2025
adthrasher
reviewed
Jan 13, 2025
|
I have a fix for the failing Windows test (we're not properly tripping the line endings in commands and multiline strings, leaving behind a trailing Once my fix PR merges, we can rebase this PR and it should hopefully go green. |
8 tasks
|
We can now rebase this on |
Co-authored-by: Andrew Thrasher <[email protected]>
peterhuene
force-pushed
the
format-idempotent
branch
from
d762772 to
3c79015
Compare
peterhuene
approved these changes
Jan 14, 2025
|
@Scott8440 thanks again for this contribution! |
|
Thanks for finishing the PR! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands format tests to also test idempotency -
format(format(source)) == format(source)Addresses #278