Move i/o before in-memory side effect in RegisteredTimeouts

stidsborg · Aug 6, 2024 · b299eae · b299eae
1 parent 453cbf2
commit b299eae
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/Core/Cleipnir.ResilientFunctions/CoreRuntime/RegisteredTimeouts.cs b/Core/Cleipnir.ResilientFunctions/CoreRuntime/RegisteredTimeouts.cs
@@ -48,14 +48,15 @@ public async Task RegisterTimeout(TimeoutId timeoutId, DateTime expiresAt)
         lock (_sync)
             if (registeredTimeouts.ContainsKey(timeoutId.Value))
                 return;
-            else
-                registeredTimeouts[timeoutId] = new RegisteredTimeout(timeoutId, expiresAt.ToUniversalTime());
 
         expiresAt = expiresAt.ToUniversalTime();
         await timeoutStore.UpsertTimeout(
             new StoredTimeout(flowId, timeoutId.Value, expiresAt.Ticks),
             overwrite: true
         );
+
+        lock (_sync)
+            registeredTimeouts[timeoutId] = new RegisteredTimeout(timeoutId, expiresAt.ToUniversalTime());
     }
 
     public Task RegisterTimeout(TimeoutId timeoutId, TimeSpan expiresIn)