Removed unused DropUnderlyingTable methods from Postgres stores

stidsborg · Sep 20, 2024 · 02d1c5a · 02d1c5a
1 parent 285d362
commit 02d1c5a
Show file tree

Hide file tree

Showing 4 changed files with 1 addition and 31 deletions.
diff --git a/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL.Tests/UtilTests/RegisterTests.cs b/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL.Tests/UtilTests/RegisterTests.cs
@@ -59,7 +59,6 @@ public override Task DeleteFailsWhenNonExpectedValueForExistingRegister()
     private async Task<IRegister> CreateAndInitializeRegister([CallerMemberName] string memberName = "")
     {
         var underlyingRegister = new PostgresSqlUnderlyingRegister(Sql.ConnectionString, tablePrefix: memberName);
-        await underlyingRegister.DropUnderlyingTable();
         await underlyingRegister.Initialize();
         return new Register(underlyingRegister);
     }

diff --git a/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlMessageStore.cs b/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlMessageStore.cs
@@ -37,16 +37,7 @@ PRIMARY KEY (type, instance, position)
         var command = new NpgsqlCommand(_initializeSql, conn);
         await command.ExecuteNonQueryAsync();
     }
-
-    private string? _dropUnderlyingTableSql;
-    public async Task DropUnderlyingTable()
-    {
-        await using var conn = await CreateConnection();
-        _dropUnderlyingTableSql ??= $"DROP TABLE IF EXISTS {_tablePrefix}_messages;";
-        var command = new NpgsqlCommand(_dropUnderlyingTableSql, conn);
-        await command.ExecuteNonQueryAsync();
-    }
-
+
     private string? _truncateTableSql;
     public async Task TruncateTable()
     {

diff --git a/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlTimeoutStore.cs b/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgreSqlTimeoutStore.cs
@@ -188,13 +188,4 @@ public async Task<IEnumerable<StoredTimeout>> GetTimeouts(FlowId flowId)
 
         return storedMessages;
     }
-
-    private string? _dropUnderlyingTableSql;
-    public async Task DropUnderlyingTable()
-    {
-        await using var conn = await CreateConnection();
-        _dropUnderlyingTableSql ??= $"DROP TABLE IF EXISTS {_tablePrefix}_timeouts;";
-        var command = new NpgsqlCommand(_dropUnderlyingTableSql, conn);
-        await command.ExecuteNonQueryAsync();
-    }
 }
diff --git a/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgresSqlUnderlyingRegister.cs b/Stores/PostgreSQL/Cleipnir.ResilientFunctions.PostgreSQL/PostgresSqlUnderlyingRegister.cs
@@ -23,17 +23,6 @@ PRIMARY KEY (registertype, groupname, name)
         await command.ExecuteNonQueryAsync();
     }
 
-    private string? _dropUnderlyingTableSql;
-    public async Task DropUnderlyingTable()
-    {
-        await using var conn = new NpgsqlConnection(connectionString);
-        await conn.OpenAsync();
-
-        _dropUnderlyingTableSql ??= $"DROP TABLE IF EXISTS {tablePrefix}_register";
-        await using var command = new NpgsqlCommand(_dropUnderlyingTableSql, conn);
-        await command.ExecuteNonQueryAsync();
-    }
-
     private string? _setIfEmptySql;
     public async Task<bool> SetIfEmpty(RegisterType registerType, string group, string name, string value)
     {