Removed IExposeState functionality

Cleipnir.Flows.Tests/Flows/FlowsWithStateTests.cs

@@ -24,7 +24,7 @@ public async Task ParamlessFlowWithStateCanBeFetchedAfterExecution()
         var flows = new ParamlessWithStateFlows(flowsContainer);
         await flows.Run("someInstanceId");
 
-        var state = await flows.GetState("someInstanceId");
+        var state = await (await flows.ControlPanel("someInstanceId"))!.States.Get<ParamlessWithStateFlow.WorkflowState>();
         state.ShouldNotBeNull();
         state.Boolean.ShouldBeTrue();
 
@@ -49,15 +49,15 @@ public async Task ActionFlowWithStateCanBeFetchedAfterExecution()
         var flows = new ActionWithStateFlows(flowsContainer);
         await flows.Run("someInstanceId", "someParameter");
 
-        var state = await flows.GetState("someInstanceId");
+        var state = await (await flows.ControlPanel("someInstanceId"))!.States.Get<ActionWithStateFlow.WorkflowState>();
         state.ShouldNotBeNull();
         state.Value.ShouldBe("someParameter");
 
         var controlPanel = await flows.ControlPanel(instanceId: "someInstanceId");
         controlPanel.ShouldNotBeNull();
         controlPanel.Status.ShouldBe(Status.Succeeded);
 
-        var flowState = controlPanel.States.Get<FuncWithStateFlow.WorkflowState>();
+        var flowState = await controlPanel.States.Get<FuncWithStateFlow.WorkflowState>();
         flowState.ShouldNotBeNull();
         flowState.Value.ShouldBe("someParameter");
     }
@@ -78,7 +78,7 @@ public async Task FuncFlowWithStateCanBeFetchedAfterExecution()
         var flows = new FuncWithStateFlows(flowsContainer);
         await flows.Run("someInstanceId", "someParameter");
 
-        var state = await flows.GetState("someInstanceId");
+        var state = await (await flows.ControlPanel("someInstanceId"))!.States.Get<FuncWithStateFlow.WorkflowState>();
         state.ShouldNotBeNull();
         state.Value.ShouldBe("someParameter");
 
@@ -87,21 +87,20 @@ public async Task FuncFlowWithStateCanBeFetchedAfterExecution()
         controlPanel.Result.ShouldBe("someParameter");
         controlPanel.Status.ShouldBe(Status.Succeeded);
 
-        var flowState = controlPanel.States.Get<FuncWithStateFlow.WorkflowState>();
+        var flowState = await controlPanel.States.Get<FuncWithStateFlow.WorkflowState>();
         flowState.ShouldNotBeNull();
         flowState.Value.ShouldBe("someParameter");
     }
 }
 
 [GenerateFlows]
-public class ActionWithStateFlow : Flow<string>, IExposeState<ActionWithStateFlow.WorkflowState>
+public class ActionWithStateFlow : Flow<string>
 {
-    public required WorkflowState State { get; init; }
-
-    public override Task Run(string param)
+    public override async Task Run(string param)
     {
-        State.Value = param;
-        return Task.CompletedTask;
+        var state = await Workflow.States.CreateOrGetDefault<WorkflowState>();
+        state.Value = param;
+        await state.Save();
     }
 
     public class WorkflowState : FlowState
@@ -111,14 +110,14 @@ public class WorkflowState : FlowState
 }
 
 [GenerateFlows]
-public class FuncWithStateFlow : Flow<string, string>, IExposeState<FuncWithStateFlow.WorkflowState>
+public class FuncWithStateFlow : Flow<string, string>
 {
-    public required WorkflowState State { get; init; }
-
-    public override Task<string> Run(string param)
+    public override async Task<string> Run(string param)
     {
-        State.Value = param;
-        return Task.FromResult(param);
+        var state = await Workflow.States.CreateOrGetDefault<WorkflowState>();
+        state.Value = param;
+        await state.Save();
+        return param;
     }
 
     public class WorkflowState : FlowState
@@ -128,14 +127,13 @@ public class WorkflowState : FlowState
 }
 
 [GenerateFlows]
-public class ParamlessWithStateFlow : Flow, IExposeState<ParamlessWithStateFlow.WorkflowState>
+public class ParamlessWithStateFlow : Flow
 {
-    public required WorkflowState State { get; init; }
-
-    public override Task Run()
+    public override async Task Run()
     {
-        State.Boolean = true;
-        return Task.CompletedTask;
+        var state = await Workflow.States.CreateOrGetDefault<WorkflowState>();
+        state.Boolean = true;
+        await state.Save();
     }
 
     public class WorkflowState : FlowState

Cleipnir.Flows/CrossCutting/CallChain.cs

@@ -22,9 +22,9 @@ public static Next<TFlow, TParam, TResult> Create<TFlow, TParam, TResult>(
                     var result = await runFlow(p, w);
                     return new Result<TResult>(result);
                 }
-                catch (SuspendInvocationException suspendInvocationException)
+                catch (SuspendInvocationException)
                 {
-                    return new Result<TResult>(Suspend.While(suspendInvocationException.ExpectedInterruptCount.Value));
+                    return new Result<TResult>(Suspend.Invocation);
                 }
                 catch (PostponeInvocationException postponeInvocationException)
                 {

Cleipnir.Flows/Flows.cs

@@ -50,38 +50,11 @@ private static Action<TFlow, Workflow> CreateWorkflowSetter()
         var setter = lambdaExpr.Compile();
         return setter;
     }
-
-    private static Action<TFlow, States> CreateStateSetter()
-    {
-        var iExposeStateType = typeof(TFlow)
-            .GetInterfaces()
-            .SingleOrDefault(i => i.IsGenericType && i.GetGenericTypeDefinition() == typeof(IExposeState<>));
-
-        if (iExposeStateType == null)
-            return (_, _) => { };
-
-        var stateType = iExposeStateType.GenericTypeArguments[0];
-
-        //fetch state
-        var methodInfo = typeof(States)
-            .GetMethods()
-            .Single(m => m.Name == nameof(States.CreateOrGet) && !m.GetParameters().Any());
-
-        var genericMethodInfo = methodInfo.MakeGenericMethod(stateType);
-        var statePropertyInfo = iExposeStateType.GetProperty("State");
-
-        return (flow, states) =>
-        {
-            var state = genericMethodInfo.Invoke(states, parameters: null);
-            statePropertyInfo!.SetValue(flow, state);
-        };
-    }
 
     protected Next<TFlow, TParam, TResult> CreateMiddlewareCallChain<TParam, TResult>(Func<TFlow, TParam, Task<TResult>> runFlow) where TParam : notnull
     {
         var serviceProvider = FlowsContainer.ServiceProvider;
         var workflowSetter = CreateWorkflowSetter();
-        var stateSetter = CreateStateSetter();
         return CallChain.Create<TFlow, TParam, TResult>(
             FlowsContainer.Middlewares,
             runFlow: async (param, workflow) =>
@@ -90,7 +63,6 @@ protected Next<TFlow, TParam, TResult> CreateMiddlewareCallChain<TParam, TResult
 
                 var flow = scope.ServiceProvider.GetRequiredService<TFlow>();
                 workflowSetter(flow, workflow);
-                stateSetter(flow, workflow.States);
 
                 var result = await runFlow(flow, param);
                 return result;

Samples/Cleipnir.Flows.Sample.Presentation/C_NewsletterSender/Solution/NewsletterFlow.cs

@@ -6,7 +6,7 @@
 namespace Cleipnir.Flows.Sample.Presentation.C_NewsletterSender.Solution;
 
 [GenerateFlows]
-public class NewsletterFlow : Flow<MailAndRecipients>, IExposeState<NewsletterFlow.NewsletterState>
+public class NewsletterFlow : Flow<MailAndRecipients>
 {
     public required NewsletterState State { get; init; }
 

Samples/Cleipnir.Flows.Sample.Presentation/F_SmsVerificationFlow/SmsFlow.cs

@@ -4,7 +4,7 @@
 namespace Cleipnir.Flows.Sample.Presentation.F_SmsVerificationFlow;
 
 [GenerateFlows]
-public class SmsFlow : Flow<string>, IExposeState<SmsFlow.SmsState>
+public class SmsFlow : Flow<string>
 {
     public required SmsState State { get; init; }
 

Samples/Cleipnir.Flows.Samples.Console/State/StateFlow.cs

@@ -3,7 +3,7 @@
 namespace Cleipnir.Flows.Sample.ConsoleApp.State;
 
 [GenerateFlows]
-public class StateFlow : Flow<string, string>, IExposeState<StateFlow.WorkflowState>
+public class StateFlow : Flow<string, string>
 {
     public required WorkflowState State { get; init; }
 

SourceGeneration/Cleipnir.Flows.SourceGenerator/FlowInformation.cs

@@ -8,7 +8,6 @@ internal class FlowInformation
         public ITypeSymbol? ParamTypeSymbol { get; }
         public string? ParameterName { get; }
         public ITypeSymbol? ResultTypeSymbol { get; }
-        public ITypeSymbol? StateTypeSymbol { get; }
         public bool Paramless { get; }
         public string AccessibilityModifier { get; }
 
@@ -17,15 +16,13 @@ public FlowInformation(
             ITypeSymbol? paramType, 
             string? parameterName, 
             ITypeSymbol? resultType, 
-            ITypeSymbol? stateTypeSymbol,
             bool paramless, 
             string accessibilityModifier)
         {
             FlowTypeSymbol = flowType;
             ParamTypeSymbol = paramType;
             ParameterName = parameterName;  
             ResultTypeSymbol = resultType;
-            StateTypeSymbol = stateTypeSymbol;
             Paramless = paramless;
             AccessibilityModifier = accessibilityModifier;
         }

SourceGeneration/Cleipnir.Flows.SourceGenerator/FlowsSourceGenerator.cs

@@ -12,13 +12,11 @@ public class FlowsSourceGenerator : IIncrementalGenerator
         private const string ParamlessFlowType = "Cleipnir.Flows.Flow";
         private const string UnitFlowType = "Cleipnir.Flows.Flow`1";
         private const string ResultFlowType = "Cleipnir.Flows.Flow`2";
-        private const string IExposeStateType = "Cleipnir.Flows.IExposeState`1";
         private const string IgnoreAttribute = "Cleipnir.Flows.SourceGeneration.Ignore";
 
         private INamedTypeSymbol? _paramlessFlowTypeSymbol;
         private INamedTypeSymbol? _unitFlowTypeSymbol;
         private INamedTypeSymbol? _resultFlowTypeSymbol;
-        private INamedTypeSymbol? _exposeStateTypeSymbol;
         private INamedTypeSymbol? _ignoreAttribute;
 
         public void Initialize(IncrementalGeneratorInitializationContext context)
@@ -46,13 +44,10 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                 _paramlessFlowTypeSymbol = complication.GetTypeByMetadataName(ParamlessFlowType);
                 _unitFlowTypeSymbol = complication.GetTypeByMetadataName(UnitFlowType);
                 _resultFlowTypeSymbol = complication.GetTypeByMetadataName(ResultFlowType);
-                _exposeStateTypeSymbol = complication.GetTypeByMetadataName(IExposeStateType);
-                if (_exposeStateTypeSymbol != null)
-                    _exposeStateTypeSymbol = _exposeStateTypeSymbol.ConstructUnboundGenericType();
                 _ignoreAttribute = complication.GetTypeByMetadataName(IgnoreAttribute);
             }
 
-            if (_paramlessFlowTypeSymbol == null || _unitFlowTypeSymbol == null || _resultFlowTypeSymbol == null || _exposeStateTypeSymbol == null)
+            if (_paramlessFlowTypeSymbol == null || _unitFlowTypeSymbol == null || _resultFlowTypeSymbol == null)
                 return null;
 
             var classDeclaration = (ClassDeclarationSyntax) context.TargetNode;
@@ -75,17 +70,6 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
 
             if (flowType.ContainingType != null || flowType.IsFileLocal)
                 return null;
-
-            ITypeSymbol? stateTypeSymbol = null;
-            foreach (var implementedInterface in flowType.AllInterfaces)
-                if (
-                    implementedInterface.IsGenericType &&
-                    SymbolEqualityComparer.Default.Equals(implementedInterface.ConstructUnboundGenericType(), _exposeStateTypeSymbol)
-                )
-                {
-                    stateTypeSymbol = implementedInterface.TypeArguments[0];
-                    break;
-                }
 
             var hasIgnoreAttribute = flowType
                 .GetAttributes()
@@ -104,7 +88,6 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                         paramType: null,
                         parameterName: null,
                         resultType: null,
-                        stateTypeSymbol,
                         paramless: true,
                         accessibilityModifier
                     )
@@ -126,7 +109,6 @@ public void Initialize(IncrementalGeneratorInitializationContext context)
                         paramType,
                         parameterName,
                         resultType,
-                        stateTypeSymbol,
                         paramless: false,
                         accessibilityModifier
                     )
@@ -145,9 +127,6 @@ private GeneratedFlowInformation GenerateCode(FlowInformation flowInformation)
             var resultType = flowInformation.ResultTypeSymbol != null 
                 ? GetFullyQualifiedName(flowInformation.ResultTypeSymbol)
                 : null;
-            var stateType = flowInformation.StateTypeSymbol == null
-                ? null
-                : GetFullyQualifiedName(flowInformation.StateTypeSymbol);
 
             var accessibilityModifier = flowInformation.AccessibilityModifier;
 
@@ -197,16 +176,6 @@ private GeneratedFlowInformation GenerateCode(FlowInformation flowInformation)
     #nullable disable
 }}";
             }
-
-            if (flowInformation.StateTypeSymbol != null)
-            {   
-                var getStateStr = $@"
-
-        public Task<{stateType}?> GetState(string instanceId) 
-            => GetState<{stateType}>(instanceId);";
-                var constructorEndPosition = generatedCode.IndexOf("{ }", StringComparison.Ordinal);
-                generatedCode = generatedCode.Insert(constructorEndPosition + 3, getStateStr);
-            }
 
             return new GeneratedFlowInformation(generatedCode, GetFileName(flowInformation));
         }

SourceGeneration/Cleipnir.Flows.SourceGeneratorDebugger/Program.cs

@@ -22,7 +22,7 @@ public static async Task Main(string[] args)
 }
 
 [GenerateFlows]
-public class SimpleFlow : Flow, IExposeState<SimpleFlow.FlowState>
+public class SimpleFlow : Flow
 {
     public required FlowState State { get; init; }