Colorize the Record/Stop button #15
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This makes it much more obvious if I forget to stop the recording.
There is no clearly visible visual change from this, but it's theoretically better depending on the WM's behavior.
|
P.s.: if merging this along with my other (docs) branch, I suggest using the "rebase" merge type in github to ensure the history remains linear, as non-fast-forward commits for such trivial branches seems overkill to me. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some trivial changes to make the Record/Stop button colorful. It now looks like this:
Also make dialogs modal and parented for great justice.
I ran the app by executing
python3 ui.pyin the pulsecaster GUI and it didn't seem like I broke anything, but please give it a shot.