-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ENH: Add rule to remove downtime #297
Open
lizsalmon
wants to merge
5
commits into
main
Choose a base branch
from
patch-reboot-complete
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Let the patch and reboot action end just after starting a reboot and then use a sensor to pick up when the machine is back before removing the downtime.
Also added "EMPTY" and "DOWN"
lizsalmon
changed the title
Add rule to remove downtime
ENH: Add rule to remove downtime
Jan 15, 2025
lizsalmon
force-pushed
the
patch-reboot-complete
branch
from
January 15, 2025 16:45
ea43ded
to
713875b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #297 +/- ##
=======================================
Coverage 98.14% 98.15%
=======================================
Files 126 126
Lines 4575 4599 +24
Branches 242 244 +2
=======================================
+ Hits 4490 4514 +24
Misses 76 76
Partials 9 9 ☔ View full report in Codecov by Sentry. |
Update icinga downtime actions and tests to use IcingaObject enums
lizsalmon
force-pushed
the
patch-reboot-complete
branch
from
January 16, 2025 09:08
713875b
to
2daac3b
Compare
gmatthews20
requested changes
Jan 16, 2025
lizsalmon
force-pushed
the
patch-reboot-complete
branch
2 times, most recently
from
January 17, 2025 09:52
8a7496f
to
6466ae4
Compare
meoflynn
reviewed
Jan 20, 2025
lizsalmon
force-pushed
the
patch-reboot-complete
branch
10 times, most recently
from
January 21, 2025 12:24
2b006fe
to
6732f55
Compare
Changed criteria to be either DOWN or DRAINED Added the exception into hv_patch_and_reboot
lizsalmon
force-pushed
the
patch-reboot-complete
branch
from
January 21, 2025 12:27
6732f55
to
0a23b1c
Compare
gmatthews20
approved these changes
Jan 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
This PR:
hypervisor_states.py
to add states for all possible machines. REBOOTED, EMPTY, DOWNSubmitter:
Have you (where applicable):
Reviewer
Does this PR:
lib
directory?lib
layers?