Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changed tests to use pytest instead of unittest. #294

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

lizsalmon
Copy link
Contributor

@lizsalmon lizsalmon commented Dec 20, 2024

Description:

  • After a discussion with Anish I've changed some of the unittest classes to be pytest tests and added pytest.fixtures if needed.
  • There are a few changes that I am unsure of with the fixtures (specifically in test_hypervisor_state_sensor.

Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.68%. Comparing base (e513a8e) to head (7a57980).
Report is 16 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #294   +/-   ##
=======================================
  Coverage   97.68%   97.68%           
=======================================
  Files         135      135           
  Lines        4875     4878    +3     
  Branches      266      265    -1     
=======================================
+ Hits         4762     4765    +3     
  Misses        102      102           
  Partials       11       11           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant