ENH: Move to query package #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace openstack query to use new package
Remove openstack_query files from lib and respective unit tests, these are now in a dedicated repository, stfc/openstack-query-library
gmatthews20
force-pushed
the
move-to-query-package
branch
from
2f983a0 to
1062dc8
Compare
Fix broken import in test Change naming to be consistant Update links in docs
gmatthews20
force-pushed
the
move-to-query-package
branch
from
1062dc8 to
aeebed9
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #290 +/- ##
==========================================
- Coverage 98.24% 97.68% -0.57%
==========================================
Files 239 135 -104
Lines 9028 4875 -4153
Branches 529 266 -263
==========================================
- Hits 8870 4762 -4108
+ Misses 137 102 -35
+ Partials 21 11 -10 ☔ View full report in Codecov by Sentry. |
Bump query library version to v0.1.3
Bump query library version to v0.1.4
gmatthews20
force-pushed
the
move-to-query-package
branch
from
e4a734d to
798a31a
Compare
Update HypervisorSate enum so it's easier to understand and use Refactor check valid sate into separate function Return HypervisorState instead of string from get_hypervisor_state Update tests Update to work with new version of query library
gmatthews20
force-pushed
the
move-to-query-package
branch
from
798a31a to
5363a77
Compare
Add new server query to find number of servers on a hypervisor
gmatthews20
force-pushed
the
move-to-query-package
branch
5 times, most recently
from
81397f6 to
8a78c64
Compare
Change current state to use the name of hypervisorstate enum as expected
gmatthews20
force-pushed
the
move-to-query-package
branch
from
8a78c64 to
d964134
Compare
anish-mudaraddi
previously approved these changes
Dec 16, 2024
|
|
||
|
|
||
| def test_get_state_unkown_status(): | ||
| """ | ||
| Test hypervisor state is unknown when missing status | ||
| """ | ||
| hypervisor = { | ||
| "hypervisor_uptime": "13:37:30 up 100 days, 4:29, 19 users, load average: 0.04, 0.04, 0.0", | ||
| "hypervisor_uptime_days": 100, |
There was a problem hiding this comment.
Is there an upper and/or lower limit to this or can it be any amount of days?
There was a problem hiding this comment.
This is the value return by the hypervisor for time since its last update so has no upper limit, I guess the lower limit is 0
There was a problem hiding this comment.
Cool cool, was just wondering if there was a test case for 0 or an upper limit if it existed.
Remove line about query library development
Dmitry-Popovichev
approved these changes
Dec 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Query Library has been moved to its own dedicated repository: https://github.com/stfc/openstack-query-library
This PR removes the query library directories and changes the stackstorm workflows to use the new package from the query library repository
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?