ENH: add image search actions #277
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #277 +/- ##
=======================================
Coverage 98.24% 98.24%
=======================================
Files 239 239
Lines 9028 9028
Branches 529 529
=======================================
Hits 8870 8870
Misses 137 137
Partials 21 21 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
| from_projects: | ||
| description: "(Optional) comma-spaced list of projects id/names to limit query to, if not provided, runs against all projects" | ||
| type: array | ||
| default: null | ||
| required: false | ||
| all_projects: | ||
| type: boolean | ||
| description: "tick to search in all projects - default True" | ||
| required: true | ||
| default: true |
There was a problem hiding this comment.
@anish-mudaraddi Is all_projects needed if when from_projects is not provided it runs against all projects?
There was a problem hiding this comment.
On this if from_projects and all_projects are false the it will default to searching the admin project
Might be worth changing the from_projects description to something along the lines of: (Optional) comma-spaced list of projects id/names to limit query to, if not provided, runs against all projects when all_projects is true
There was a problem hiding this comment.
Have changed the description in all the image search actions now thank you
Also added the action for searching images by using regex
Since the image ids would be unique, it would not be possible to group them. So removed it
- Fixed group by parameter to include null enum as default - Removed string properties to select from expression search action
Neonbluestoplight
force-pushed
the
image-search-action
branch
from
325d1ed to
fded020
Compare
Earlier description did not highlight that all_projects flag still has to be enabled for the action to run
Neonbluestoplight
force-pushed
the
image-search-action
branch
from
1f205b5 to
7dc8916
Compare
written by @Neonbluestoplight
Description:
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
libdirectory?liblayers?