Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Make sure email addresses to email are provided as a list #149

Merged
merged 1 commit into from
Oct 5, 2023

Conversation

meoflynn
Copy link
Collaborator

@meoflynn meoflynn commented Oct 5, 2023

Description:

If an email address has something like an apostrophe, it will split the email address into individual characters. Email params has been updated to take email addresses as a list of addresses


Submitter:

Have you (where applicable):

  • Added unit tests?
  • Checked the latest commit runs on Dev?
  • Updated the example config file(s) and README?

Reviewer

Does this PR:

  • Place non-StackStorm code into the lib directory?
  • Have unit tests for the action/sensor and lib layers?
  • Have clear and obvious action parameter names and descriptions?

@meoflynn meoflynn added the bug Something isn't working label Oct 5, 2023
@codecov
Copy link

codecov bot commented Oct 5, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (724476b) 97.16% compared to head (f0a51de) 97.16%.
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #149   +/-   ##
=======================================
  Coverage   97.16%   97.16%           
=======================================
  Files         134      134           
  Lines        5925     5925           
  Branches      404      404           
=======================================
  Hits         5757     5757           
  Misses        138      138           
  Partials       30       30           
Files Coverage Δ
lib/custom_types/email_api/aliases.py 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@DavidFair DavidFair left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is my fault, I forgot that it's an alias that's imported, we should revert this file (git checkout main <path/to/file>)

Then change it here: https://github.com/stfc/st2-cloud-pack/blob/main/lib/custom_types/email_api/aliases.py#L4

lib/structs/email/email_params.py Outdated Show resolved Hide resolved
If an email address has something like an apostrophe, it will split the email address into
individual characters. Email params has been updated to take email addresses as a list of addresses
@meoflynn meoflynn requested a review from DavidFair October 5, 2023 10:37
@DavidFair DavidFair merged commit 9ac8b46 into main Oct 5, 2023
@DavidFair DavidFair deleted the email_param_list branch October 5, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants