MAINT: Refactor to use factory pattern #146
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anish-mudaraddi
force-pushed
the
openstack-query/factory-pattern
branch
from
927b674 to
31ac81e
Compare
This dataclass will be used to store query blocks
this is a better suited name since these classes only hold mapping info fixup mapping interface
Remove QueryWrapper, use QueryFactory to create a QueryAPI object using QueryComponents Dataclass Move QueryAPI to api sub-module Add QueryBlocks as a way of accessing Query Objects in similar manner as before
update import paths mostly
refactor query_api tests, add tests for new classes
anish-mudaraddi
force-pushed
the
openstack-query/factory-pattern
branch
from
31ac81e to
555782a
Compare
Codecov ReportAll modified lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #146 +/- ##
==========================================
+ Coverage 97.16% 97.17% +0.01%
==========================================
Files 134 142 +8
Lines 5925 6128 +203
Branches 404 410 +6
==========================================
+ Hits 5757 5955 +198
- Misses 138 144 +6
+ Partials 30 29 -1
☔ View full report in Codecov by Sentry. |
|
Needs tests for Mappings |
DavidFair
reviewed
Oct 4, 2023
anish-mudaraddi
force-pushed
the
openstack-query/factory-pattern
branch
2 times, most recently
from
142c9b6 to
9c64e43
Compare
DavidFair
requested changes
Oct 4, 2023
DavidFair
requested changes
Oct 4, 2023
anish-mudaraddi
force-pushed
the
openstack-query/factory-pattern
branch
2 times, most recently
from
bc33ccc to
709bc95
Compare
checks mappings are expected for each query mappings class
anish-mudaraddi
force-pushed
the
openstack-query/factory-pattern
branch
from
709bc95 to
4cb8a20
Compare
|
I've added client-side mapping tests - and altered server-side tests to ensure that there is an equivalent client-side test (to allow queries using |
DavidFair
requested changes
Oct 5, 2023
DavidFair
approved these changes
Oct 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
change to now use a factory pattern to create queries
decouple query mappings and query components from queries
This will make chaining from one query to another easier