Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Refactor struct module to use pytest #144

Merged

Conversation

anish-mudaraddi
Copy link
Collaborator

refactor struct module tests to use pytest fixtures and conventions

@codecov
Copy link

codecov bot commented Oct 3, 2023

Codecov Report

Attention: 2 lines in your changes are missing coverage. Please review.

Comparison is base (e11ff2a) 97.48% compared to head (d56cbea) 97.62%.
Report is 16 commits behind head on main.

❗ Current head d56cbea differs from pull request most recent head 5d83632. Consider uploading reports for the commit 5d83632 to get more accurate results

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #144      +/-   ##
==========================================
+ Coverage   97.48%   97.62%   +0.14%     
==========================================
  Files         174      174              
  Lines        7011     7046      +35     
  Branches      436      437       +1     
==========================================
+ Hits         6835     6879      +44     
+ Misses        145      136       -9     
  Partials       31       31              
Files Coverage Δ
...uery/handlers/test_client_side_handler_datetime.py 100.00% <100.00%> (ø)
tests/structs/test_email_params.py 100.00% <100.00%> (ø)
tests/structs/test_query_output_details.py 100.00% <100.00%> (ø)
tests/structs/test_smtp_account.py 100.00% <100.00%> (ø)
...query/handlers/test_client_side_handler_generic.py 96.00% <95.45%> (ø)
...query/handlers/test_client_side_handler_integer.py 95.45% <95.00%> (ø)

... and 11 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@anish-mudaraddi anish-mudaraddi force-pushed the openstac-query/re-write-struct-tests branch from 82ac172 to d56cbea Compare October 3, 2023 10:50
meoflynn
meoflynn previously approved these changes Oct 3, 2023
tests/structs/test_smtp_account.py Outdated Show resolved Hide resolved
@anish-mudaraddi anish-mudaraddi force-pushed the openstac-query/re-write-struct-tests branch from c19c5d5 to 5d83632 Compare October 3, 2023 11:06
@DavidFair DavidFair merged commit 58543b2 into stfc:main Oct 3, 2023
@anish-mudaraddi anish-mudaraddi deleted the openstac-query/re-write-struct-tests branch October 13, 2023 09:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants