-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Hotfix user not returning list #139
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #139 +/- ##
==========================================
+ Coverage 97.48% 97.61% +0.12%
==========================================
Files 174 174
Lines 7011 7048 +37
Branches 436 438 +2
==========================================
+ Hits 6835 6880 +45
+ Misses 145 137 -8
Partials 31 31
☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
rewrite your tests once #141 is merged
add a workaround to allow querying by id using conn.identity.find_user
This resolves an issue where the calling method expects a list back, but instead gets a singular value
6850e74
to
f6a26bd
Compare
Fixes a bug where we are passing the string 'id' rather than a real ID that was selected
Fixes some doc-strings which refer to servers when we are in a user query instead
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Description:
Fixes UserRunner not returning a list, this was seen by @meoflynn
Special Notes:
Submitter:
Have you (where applicable):
Reviewer
Does this PR:
lib
directory?lib
layers?