MAINT: fix code-cov issue

stfc · Oct 13, 2023 · f1bbf21 · f1bbf21
1 parent d7dd174
commit f1bbf21
Show file tree

Hide file tree

Showing 5 changed files with 6 additions and 6 deletions.
diff --git a/tests/lib/openstack_query/mappings/conftest.py b/tests/lib/openstack_query/mappings/conftest.py
@@ -113,7 +113,7 @@ def _server_side_any_in_test_case(
         server_side_handler: ServerSideHandler,
         client_side_handler: ClientSideHandler,
         expected_mappings: Dict[PropEnum, str],
-        test_cases: Optional[Dict] = None,
+        test_cases: Dict,
     ):
         """
         Tests server side handler mappings for ANY_IN preset are correct, and line up to the expected
@@ -129,9 +129,6 @@ def _server_side_any_in_test_case(
             QueryPresetsGeneric.ANY_IN
         )
 
-        if not test_cases:
-            test_cases = {"test1": "test1", "test2": "test2"}
-
         assert all(
             key_to_check in supported_props for key_to_check in expected_mappings
         )

diff --git a/tests/lib/openstack_query/mappings/test_flavor_mapping.py b/tests/lib/openstack_query/mappings/test_flavor_mapping.py
@@ -11,14 +11,14 @@
 
 def test_get_runner_mapping():
     """
-    Tests get runner mapping returns a server runner
+    Tests get runner mapping returns a flavor runner
     """
     assert FlavorMapping.get_runner_mapping() == FlavorRunner
 
 
 def test_get_prop_mapping():
     """
-    Tests get prop mapping returns a server properties
+    Tests get prop mapping returns a flavor properties
     """
     assert FlavorMapping.get_prop_mapping() == FlavorProperties
 

diff --git a/tests/lib/openstack_query/mappings/test_project_mapping.py b/tests/lib/openstack_query/mappings/test_project_mapping.py
@@ -91,6 +91,7 @@ def test_server_side_handler_mappings_any_in(server_side_any_in_mappings):
         ProjectMapping.get_server_side_handler(),
         ProjectMapping.get_client_side_handlers().generic_handler,
         mappings,
+        {"test1": "test1", "test2": "test2"},
     )
 
 

diff --git a/tests/lib/openstack_query/mappings/test_server_mapping.py b/tests/lib/openstack_query/mappings/test_server_mapping.py
@@ -79,6 +79,7 @@ def test_server_side_handler_mappings_any_in(server_side_any_in_mappings):
         ServerMapping.get_server_side_handler(),
         ServerMapping.get_client_side_handlers().generic_handler,
         mappings,
+        {"test1": "test1", "test2": "test2"},
     )
 
 

diff --git a/tests/lib/openstack_query/mappings/test_user_mapping.py b/tests/lib/openstack_query/mappings/test_user_mapping.py
@@ -64,6 +64,7 @@ def test_server_side_handler_mappings_any_in(server_side_any_in_mappings):
         UserMapping.get_server_side_handler(),
         UserMapping.get_client_side_handlers().generic_handler,
         mappings,
+        {"test1": "test1", "test2": "test2"},
     )