Improve accounting scripts #95
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
meoflynn
requested changes
Oct 5, 2023
OpenStack-accounting/usr/local/sbin/manila_extract_accounting.py
Outdated
Show resolved
Hide resolved
anish-mudaraddi
requested changes
Oct 5, 2023
OpenStack-accounting/usr/local/sbin/cinder_extract_accounting.py
Outdated
Show resolved
Hide resolved
OpenStack-accounting/usr/local/sbin/cinder_extract_accounting.py
Outdated
Show resolved
Hide resolved
OpenStack-accounting/usr/local/sbin/glance_extract_accounting.py
Outdated
Show resolved
Hide resolved
OpenStack-accounting/usr/local/sbin/glance_extract_accounting.py
Outdated
Show resolved
Hide resolved
|
@anish-mudaraddi @meoflynn @DavidFair I believe I've addressed your feedback on this. |
meoflynn
requested changes
Oct 6, 2023
apdibbo
changed the title
|
I think this is ready now |
meoflynn
requested changes
Oct 23, 2023
meoflynn
requested changes
Oct 23, 2023
| This procedure generates accounting data for cinder | ||
| */ | ||
| SELECT | ||
| IFNULL(v.availability_zone, 'nova') AS AvailabilityZone, |
There was a problem hiding this comment.
Just to double check, here is it only selecting nova as the availability zone if there isn't an availability zone for a given volume (e.g. volume doesn't have a ceph availability zone and is just null)?
There was a problem hiding this comment.
Yes, that is what that's doing
meoflynn
previously approved these changes
Oct 23, 2023
DavidFair
previously approved these changes
Oct 31, 2023
anish-mudaraddi
approved these changes
Nov 21, 2023
DavidFair
approved these changes
Nov 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convert to Python3
Use dedicated accounting database user
Improvements to the accounting suite
Add accounting for other components