Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some fixes and improvements #19

Closed
wants to merge 11 commits into from
Closed

Some fixes and improvements #19

Changes from 1 commit
Commits
Show all changes
11 commits
Select commit Hold shift + click to select a range
90a04a9
Adapt for parse cookie partitionKey when it is str
yoori Nov 17, 2024
1d6ea84
Added chrome stderr output to Exception when chrome start failed (hel…
yoori Nov 17, 2024
12806e4
adapt for websockets 14.0 : websocket.closed attribute removed
yoori Nov 17, 2024
0558831
Added getter for get browser process output (help to debug chrome ins…
yoori Nov 17, 2024
570df12
Fix: don't drop CDP message id counter (this can be reason for id rep…
yoori Nov 17, 2024
97390c1
More accurate handling of exceptions, that can interrupt websocket re…
yoori Nov 17, 2024
b9254fb
adapt for websockets 14.0
yoori Nov 17, 2024
8f5ae76
Added lost dependency of package on requests module
yoori Nov 17, 2024
8c46e56
Merge branch 'stephanlensky:main' into main
yoori Nov 17, 2024
ab058aa
Update zendriver/core/browser.py
yoori Nov 18, 2024
c928027
Set zendriver dependency python>=3.9
yoori Nov 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ classifiers = [
"Programming Language :: Python :: 3.12",
"Programming Language :: Python :: 3.13",
]
requires-python = ">=3.10"
requires-python = ">=3.9"
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hey, this change needs to be reverted if you want this PR to get merged - I am sticking with >=3.10 for the X | Y union syntax for type annotations.

BTW, sorry for the delay in responding, I need to do some further research to understand the websockets==14.0 changes.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can I replace|with typing.Union ? I need 3.9 compatibility …

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, I recreated MR, (can't find way to change branch in already created MR), I can't rollback python 3.9 adaptation in main and created MR with other branch : #22

dependencies = [
"requests",
"asyncio-atexit>=1.0.1",
Expand Down