[finalize-warmboot.sh] reset cpufreq governor to default #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Stepan Blyschak <[email protected]>
stepanblyschak
force-pushed
the
cpufreq-governor
branch
from
ef1b3d8
to
51ef6a2
Compare
volodymyrsamotiy
approved these changes
Jul 18, 2024
nazariig
suggested changes
Jul 18, 2024
| @@ -101,16 +101,30 @@ function check_list() | |||
| echo ${RET_LIST} | |||
| } | |||
|
|
|||
| function set_cpufreq_governor() { | |||
| governor="$1" | |||
| echo "$governor" | tee /sys/devices/system/cpu/cpu*/cpufreq/scaling_governor \ | |||
There was a problem hiding this comment.
@stepanblyschak tee stdout is redundant. Can we hide it?
nazariig
suggested changes
Jul 18, 2024
| @@ -101,16 +101,30 @@ function check_list() | |||
| echo ${RET_LIST} | |||
| } | |||
|
|
|||
| function set_cpufreq_governor() { | |||
| governor="$1" | |||
nazariig
suggested changes
Jul 18, 2024
| @@ -101,16 +101,30 @@ function check_list() | |||
| echo ${RET_LIST} | |||
| } | |||
|
|
|||
| function set_cpufreq_governor() { | |||
There was a problem hiding this comment.
@stepanblyschak do we need to add a check that if current CPU governor is not equal to what we set then proceed, otherwise - exit?
There was a problem hiding this comment.
@nazariig don't see a benefit from such check
Signed-off-by: Stepan Blyschak <[email protected]>
nazariig
approved these changes
Jul 18, 2024
stepanblyschak
pushed a commit
that referenced
this pull request
Aug 22, 2024
…utomatically (sonic-net#19920) #### Why I did it src/sonic-host-services ``` * d62c874 - (HEAD -> 202311, origin/202311) Added a try block to prevent JSON decoder errors (#126) (10 hours ago) [Ashwin Srinivasan] ``` #### How I did it #### How to verify it #### Description for the changelog
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why I did it
Set cpufreq.default_governor to performance for faster boot time. We observe consistent 1 sec improvement across several devices.
The change in finalize-warmboot.sh restores the default governor after fast or warm boot is finished.
NOTE: This will apply to upgrades starting from 202405 since this is set in shutdown path to avoid any extra scripts running at boot time. Upgrade from older versions/branches will require a runtime patch to fast-reboot and warm-reboot script.
Work item tracking
How I did it
After fast or warm boot is finished restore to default governor.
How to verify it
Run fast-reboot or warm-reboot. Check:
After boot is finalized check that it is reset back to default:
Which release branch to backport (provide reason below if selected)
Tested branch (Please provide the tested image version)
Description for the changelog
Link to config_db schema for YANG module changes
A picture of a cute animal (not mandatory but encouraged)