Fixed key event handling for OpenGL views on macOS #307
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
acceptsFirstResponder
,becomeFirstResponder
andresignFirstResponder
methods in the opengl class make it possible for keyboard events to be caught by the (parent) view, otherwise it doesn't work if we don't have them.The line in
CocoaOpenGLView::viewSizeChanged()
fixes an issue in Logic Pro and GarageBand where when you change the view size, the key event handling stops working even though the opengl view is still the first responder. Making the parent view the first responder fixes this problem. When you click on the opengl view, it becomes the first responder again and key events work.I had to implement all key modifier flags on macOS for the fake/simulated keyUp event in
flagsChanged
to work properly:https://developer.apple.com/documentation/appkit/nseventmodifierflags
I have been testing this on Reaper, Ableton Live, Logic Pro and GarageBand.