Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

API testing and JSON validator setup #224

Merged
merged 54 commits into from
Jun 6, 2024
Merged

API testing and JSON validator setup #224

merged 54 commits into from
Jun 6, 2024

Conversation

creme332
Copy link
Member

@creme332 creme332 commented Jun 6, 2024 •
edited
Loading

Checklist

Confirm you have completed the following actions prior to submitting this PR.

  • There is an existing issue report for this PR.
  • This is not a duplicate of an existing pull request.
  • My pull request is not resolving multiple issues at once.
  • I have created a feature branch.
  • My commit messages are detailed.
  • All of my commits are relevant to the issue.
  • composer test does not throw any error.

Issue Resolution

Tell us which issue this PR fixes.

This pull request Fixes #XX

Additional Information

If needed, provide additional information about your pull request.

creme332 and others added 30 commits May 23, 2024 08:09
@creme332
move model tests to models folder
d23f407
@creme332
install guzzle
c6b26d8
@Divyeshhhh @creme332
add Review model table property, getAll, getAllReviewsForProduct, upd…
9fd5f71 
…ateReview, and deleteReview methods
@creme332
rewrite logic for the API to make errors clearer and to reduce code d…
88d6237 
…uplication (e.g. `getHandler` was being duplicated in all api controllers)
@Divyeshhhh @creme332
add new API endpoint to retrieve all reviews for a product by ID and …
4f404fc 
…implemente corresponding controller logic in Products and Reviews controllers
@creme332
ensure that getAll() and getAllReviewsForProduct() always return array
c2cccaa
@creme332
add getReviewByID, send appropriate errors when review attributes are…
ee4e111 
… invalid in createReview
@creme332
make $routes relative to API_BASE_URI
619030c 
make $routes relative to API_BASE_URI

add static variable $API_BASE_URI
@creme332
use testing database when request contains X-Test-Env in header
c9c6dca
@creme332
merge changes from main
a174e1e
@creme332
change namespace to Steamy\Tests\Model
b6f7e17
@creme332
replace test suite with 2 new ones: models, api
1e570f3
@creme332
add namespace for tests, add new scripts for testing testsuites
8b9df8e
@creme332
add tests for product endpoint of api
255912a
@creme332
remove unnecessary call to parent setUp in setUp since class has no p…
b9b0b02 
…arent
@creme332
use 2 separate env files for production and testing
33ecd02
@creme332
update docs based on new tests structure
9020c00
@creme332
rename folder to schemas
c8a64b0
@creme332
disallow additional properties
dc43848
@creme332
use json validation in createProduct
3074f9e
@creme332
new schema structure
826bcb4
@creme332
merge creme332:main and fix merge conflicts
ff15818
@creme332
remove incorrectly merged file
b99a556
@creme332
fix empty array bug in getAll
310b6c6 
foreach() argument must be of type array|object
@creme332
move faker to dev dependency
d61d650
@creme332
update versions so that php 8.1 is enough
6469c91
@creme332
create a test helper trait
c98a341
@creme332
use new test helper
702c0d8
@creme332
add new methods and make tests more random
5309764 
- ensure that client email is unique
- add initFaker, printFakerSeed, createStore
@creme332
add note on modifying css/js files
ff2b58d
creme332 added 21 commits June 2, 2024 19:43
@creme332
use helper functions from TestHelper
e41bf27
@creme332
remove transaction from resetDatabase
ed5e71c
@creme332
create an APIHelper trait
97ebdd8
@creme332
use test helpers
45b1acc
@creme332
remove getAllReviewsForProduct since it is already present in product…
3656517 
…s controller api
@creme332
remove irrelevant todo
c2fd70a
@creme332
fix issues
bb32665 
- use random image extension in createProduct
- improve error message in createClient, createReview, createStore
@creme332
update acceptable img extensions in validate
5633717
@creme332
add log_json
b75f50e
@creme332
remove unused import
6691f61
@creme332
fix bug in createProduct
91fcb41
@creme332
complete testCreateValidProduct and testDeleteProductById
5239abd
@creme332
create and use a helper method to validate data against schema
93a15b2
@creme332
complete updateProduct and getAllReviewsForProduct
0ad6027
@creme332
fix file path bug in validateAgainstSchema
2c8974d
@creme332
add schema for updating products
c01adc1
@creme332
reset database both before and after test suite
063ddff
@creme332
complete testUpdateProductById
6e2e57e
@creme332
add option to not save fake product and client to database
ef51a85
@creme332
rework testGetById
c1ae17c 
- split into 2 separate test functions
- compare all attributes in testGetByIDForValidId
@creme332
add better tests for updateProductById
6087356
@creme332 creme332 linked an issue Jun 6, 2024 that may be closed by this pull request
write a test helper class #219
Closed
@creme332 creme332 changed the title Guz API testing and JSON validator setup Jun 6, 2024
@creme332 creme332 merged commit bed832c into main Jun 6, 2024
1 check passed
@creme332 creme332 deleted the guz branch June 6, 2024 10:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

write a test helper class
2 participants
@creme332 @Divyeshhhh